Closed (fixed)
Project:
fancyBox
Version:
7.x-2.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
11 Jan 2012 at 09:11 UTC
Updated:
17 Jan 2013 at 21:30 UTC
Now part of fancyapps...
Version 2 is completely rewritten with new features and updated graphics.
Comments
Comment #1
dddbbb commentedI would also love to see this implemented. I have a great need for a responsive modal box system in Drupal, fancyBox 2 would be a great solution.
Comment #2
jcisio commentedFancybox 2.x requires jQuery 1.6+. Even with Drupal 7 + jQuery Update, you only get jQuery 1.5.x. So it is not evident...
Comment #3
klonosSo we should then perhaps wait on these:
#1067290: Fix jQuery 1.7 for Drupal 6
#1386294: Release jQuery 1.7 for Drupal 7
Comment #4
dddbbb commentedLooks like #1386294: Fix jQuery 1.7 for Drupal 7 is pretty much there now.
Comment #5
dddbbb commented#1386294: Fix jQuery 1.7 for Drupal 7 is now fixed.
Comment #6
bas.hr commentedI'll postpone it until we find someone who is willing to work on this task
Comment #7
yannickooI love the fancybox and I'm the maintainer of the Gallery Link module but I don't fancybox 2 cause of the new license.
Should we really support that?
Comment #8
jcisio commentedWhy not? Fancybox is still open source. We even support close source solution (MS SQL driver for Drupal is an example).
Comment #9
joelpittetYes we should. Dude has done a great job, made improvements and sells a good product. The licence for commercial sites is very reasonable as well.
Comment #10
yannickooOkay that's true. But how should we implement this? The code you need to trigger the fancybox and the options are different. Should the fancybox module detect which version of fancybox is installed (in libraries directory) and display the suitable options?
Comment #11
dddbbb commentedDetection sounds good to me but I'd go a step further and add some help text to the admin page explaining that the settings displayed are as a result of library version detection (hopefully that'll save a few support issues).
Comment #12
kingfisher64 commentedIt's the responsive bit i'm interested in. Tried the demos and loved it.
How's the progress going on upgrading fancybox to fancybox2?
Comment #13
CinemaSaville commentedAny updates on this? Also very interested.
Comment #14
bas.hr commented@yannickoo:
Code/options to trigger different minor versions (1.3.1 vs 1.3.4) was also different, thats why I lost interest in supporting such an unstable JS. Version 1.3 is buggy and it makes no sense to support it when there are better replacements such as Colorbox.
Anyway, fancybox2 should be different branch 7-2.x. I wouldn't mix both codes.
@kingfisher64 & @CinemaSaville:
No updates, everyone is waiting for magic to happen :) Are you willing to fund development?
Comment #15
kingfisher64 commentedI'm using colorbox. There's a licence fee associated with fancybox. Although it's great and the creator deserves to receieve funding, to pay for a lightbox solution everytime it's used, to me is not plausable. sorry.
Comment #16
dwieeb commentedI will be working on getting a stable branch for fancyBox 2 up. As bas.hr mentioned, it will be on the 2.x branch.
As of now, since this is a fairly simple module and the differences between version 1 and 2 of FancyBox are so extreme, I doubt the module will be upgradable from 1.x to 2.x. You'll just have to uninstall and reinstall the stable 2.x version.
Development is underway...
Comment #17
klonosGreat news! Let us know when there's something available for testing Daniel ;)
Comment #18
dwieeb commentedThis is postponed again as fancyBox2 requires at least jQuery 1.7 (as mentioned earlier in this topic), and Drupal core provides 1.4.4 and the jQuery Update module provides 1.5.2. There's talk of 1.7, but there's still some work to do.
For 2.x jQuery Update will have to be a dependency (once they update to 1.7).
Comment #19
jcisio commentedFYI jQuery Update provides 1.7.x in the latest development snapshot (there is an option to chose 1.5/1.7).
Comment #20
klonos...you got me to it Hai-Nam ;)
Comment #21
dwieeb commentedOkay, please test 7.x-2.x-dev. You can find the download on the project page. See the readme for installation and usage instructions. You will need the dev version of jQuery Update.
The functionality is largely inspired by the Colorbox module, so it should be easy to switch between the two. Let me hear your thoughts about it. Feel free to create a new issue.
These features are planned:
Any requests or comments?
Comment #22
dwieeb commentedComment #23.0
(not verified) commented...h2 instead of h1.