Notice: Trying to get property of non-object in uc_roles_cron() line 42 /ubercart/uc_roles/uc_roles.module

    if (!is_array($account->roles) || !count($account->roles)) {

to 

    if ($account && (!is_array($account->roles) || !count($account->roles))) {

The reason this error exists is that the uc_roles_expirations table has a user id that no longer exists

Hope this helps.

CommentFileSizeAuthor
#5 uc_roles.module-cron-user-fix-1402106.patch674 bytesjoelpittet
#4 uc_roles.module.patch600 bytesjoelpittet
#1 uc_roles.module.patch602 bytesjoelpittet
uc_roles.module.patch585 bytesjoelpittet

Comments

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new uc_roles.module.patch602 bytes

I attached the wrong patch and message:( see this one.

I removed the role expiration if the user doesn't exist

Status: Needs review » Needs work

The last submitted patch, uc_roles.module.patch, failed testing.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Can you reupload your patch? Both links give 404 for me, seems drupal.org has been having some trouble in the past couple of hours.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new uc_roles.module.patch600 bytes

I have attached again but just in case here is the code: 

--- a/sites/all/modules/ubercart/uc_roles/uc_roles.module
+++ b/sites/all/modules/ubercart/uc_roles/uc_roles.module
@@ -38,8 +38,14 @@ function uc_roles_cron() {
   foreach ($result as $expiration) {
     $account = user_load($expiration->uid);
 
+    // Cleanup if this user was deleted.
+    if (!$account) {
+      uc_roles_delete($expiration->uid, $expiration->rid);
+      continue;
+    }
+
     // User has to contain roles to manage.
-    if (!is_array($account->roles) || !count($account->roles)) {
+    if (!is_array($account->roles) || !count($account->roles)) {
       continue;
     }
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new uc_roles.module-cron-user-fix-1402106.patch674 bytes

Wonder if it doesn't like the patch format...

wodenx’s picture

wodenx commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, uc_roles.module-cron-user-fix-1402106.patch, failed testing.

tr’s picture

tr commented

Can we address #911350: uc_roles_cron() does not scale (horribly) at the same time please? I'd prefer to combine these into one issue, because any patch here will get lost when that routine gets refactored, and any refactoring needs to be aware of the above.

tr’s picture

tr commented
Status: Needs work » Closed (duplicate)

Closing in favor of getting this all done in #911350: uc_roles_cron() does not scale (horribly). Please contribute to that issue if you want to get this resolved.

mariagwyn’s picture

mariagwyn commented

Is this really a duplicate? The issue you reference is for 6.x, this is for 7.x

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

The fix will be the same, so it's best to work on the fix in 7.x where development is most active, then backport it to 6.x.