Check in apachesolr_do_query if the static of the query with that name already exists, and if so return it.
This is needed if a query needs to be run twice on the same page load, this way we are optimizing the process.

CommentFileSizeAuthor
#10 1402748-10.patch889 bytesnick_vh
#8 cached-1402748-8.patch633 byteskillua99
#4 1402748-4.patch7.44 KBnick_vh
#4 XHProf view | Smartphone compare-1.jpg38.15 KBnick_vh
#4 XHProf view | Smartphone compare.jpg38.11 KBnick_vh
#5 1402748-5.patch633 bytesnick_vh

Comments

milesw’s picture

milesw commented

This sounds like it could potentially resolve #1481326: Queries run twice after submitting search forms on a custom search page

pwolanin’s picture

pwolanin commented
Category: task » bug

sounds more like a bug?

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

is this an RC blocker? Don't think so

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs review » Active
StatusFileSize
new XHProf view | Smartphone compare.jpg38.11 KB
new XHProf view | Smartphone compare-1.jpg38.15 KB
new 1402748-4.patch7.44 KB

So, this patch does exactly that.

The smallest one is the improved one, so this does help performance wise, whenever you are running the same query twice on the same page. Logically, this does not change anything if you are not executing a query twice on the same page.

XHProf view | Smartphone compare-1.jpg
XHProf view | Smartphone compare.jpg

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
StatusFileSize
new 1402748-5.patch633 bytes

wrong patch file, apologies

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Active » Needs review
nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Version: 7.x-1.x-dev » 6.x-3.x-dev
Status: Active » Patch (to be ported)

needs backport, committed to 7.x-1.x

killua99’s picture

killua99 commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new cached-1402748-8.patch633 bytes

Ported, I test it with the apachesolr search module.

pwolanin’s picture

pwolanin commented

Should this check happen earlier - before the drupal_alter?

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Version: 6.x-3.x-dev » 7.x-1.x-dev
StatusFileSize
new 1402748-10.patch889 bytes

Since the query alter wouldn't do anything useful before returning the cached results, I agree here.

Patch is for 7.x-1.x

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs review » Fixed

Committed to 7.x-1.x and 6.x-3.x

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Fixed » Closed (fixed)
nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Issue summary: View changes

Updated issue summary.