I'm using a custom Rules action that calls a function which stores a static variable to be processed in hook_exit().

I've configured this action to be processed on node update/delete and flag/unflag.

This action does not function properly if drupal_exit() is not called.

I will post a patch shortly.

CommentFileSizeAuthor
#1 drupal_exit_flag_1402948_1.patch656 bytesstevector

Comments

stevector’s picture

stevector
he/him
commented
StatusFileSize
new drupal_exit_flag_1402948_1.patch656 bytes
stevector’s picture

stevector
he/him
commented
Status: Needs work » Needs review
joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

Looks like a no-brainer to me :)

socketwench’s picture

socketwench commented
Status: Reviewed & tested by the community » Fixed

Hopefully I committed that correctly:

http://drupalcode.org/project/flag.git/commit/bcb0513

Marking Fixed.

joachim’s picture

joachim commented

Looks perfect!

(You did miss a full stop at the end of the commit message, if I'm nitpicking ;) I recommend dreditor for making commit messages: http://drupal.org/project/dreditor)

socketwench’s picture

socketwench commented

I also missed the use of --author to give @stevector proper credit. >_<

socketwench’s picture

socketwench commented
Status: Fixed » Closed (fixed)

Marking closed (fixed).

joachim’s picture

joachim commented

> Marking closed (fixed).

That's done automatically by the system bot after two weeks :)

You're also credited in the git log as 'socketwench'. The convention is to use full names in git attribution -- but that's not at all a requirement, I'm just mentioning in case you'd forgotten to set up your git attributions settings.

socketwench’s picture

socketwench commented

Yeah, Daimen Mckenna on Twitter pointed that out to me and told me how to fix that in future commits. Hopefully the next two where okay.

Is it just convention to let it close automatically? Having been on the opposite side of that I've always felt it best to explicitly close it once committed.