The default CSS for nice_menus ends up looking strange in Garland due to Garland's CSS. We should make nice_menus CSS generic as possible so it looks decently benign in all of the core themes. The major thing in Garland which is weird is the border on the ul and the fact that there is a gap between li. I propose removing the borders from the CSS as the easiest and cleanest fix for the border issue. It's a simple patch but what do others think on this?
I haven't had time to look at the gap issue but I think it needs to be addressed as well.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | nice_menus_garland_fix_0.patch | 3.8 KB | add1sun |
| #1 | nice_menus_garland_fix.patch | 599 bytes | add1sun |
| nice_menus_garland.png | 20.74 KB | add1sun |
Comments
Comment #1
add1sun commentedI'm thinking not to remove the border since it may confuse people who upgrade. I did track down the funky css in garland and here is a simple patch to override the necessary css to get nice menus looking normal in garland/minelli. All of the other core themes look fine with this as well.
Comment #2
add1sun commentedBleh, Garland does funky theming to the whole header region so nice menus are completely borked there. Here is a new, much bigger patch that puts in the more specific overrides to make it work in the header as well.
Comment #3
brenda003This is working for me in all core themes, unfortunately I don't have access to IE right now to test there.
One thing, though, is the filter:mask(); doesn't validate - I'm not sure what it even *does*, I've never seen it used before. Removing it didn't seem to do anything - what's it for?
Comment #4
add1sun commentedThe filter is specifically for an IE fix to get the flyout menus to display properly over form selects. Filter activates IE's activeX rendering to make the damn thing work. :) We should probably pull that out to an IE hack file and conditionally included it so normal browsers validate OK. But that should be a separate issue.
Comment #5
Goose4all commentedi love you!
works like a charm.. ;)
thank you!!
Comment #6
add1sun commentedpatch applied to the 5 branch. thanks for testing folks!
Comment #7
(not verified) commented