Closed (won't fix)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Major
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Jan 2012 at 08:48 UTC
Updated:
17 Sep 2012 at 20:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
klausiIt appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.
manual review:
Comment #2
klausiComment #3
richard banks commentedI have applied all the necessary changes and have tested the module successfully against coder and the Drupal Code Sniffer.
Comment #4
mkadin commentedCool stuff. I didn't know about loggly, but it seems like a cool service. A bit pricey for my tastes...
Anyway, it looks like you've covered most of the automated review process, but there are a few remaining things to clear up:
Also on lines 80->88 of your .module file, you've arranged the array assignment so that the operands line up. I like this formatting, but I'm not sure that it's the drupal coding style. I could be wrong though...
For javascript files getting loaded on every page load (i.e. the drupal_add_js on line 159), you can add them in your .info file for your module. I believe this is more efficient.
Good stuff though!
Comment #5
richard banks commentedOk all those issues have been corrected as well. Third time's the charm?
Comment #6
richard banks commentedThe code now passes all the tests, what's next?
Comment #7
firebird commentedI've reviewed the module, here's what I think:
Licensing: No issues found. It looks like there is no 3rd party code.
Module duplication: There are no other modules at drupal.org that integrate with Hoover.
Overall understanding of Drupal API's: Looks good to me.
Security: No problems found.
Drupal coding standards: PAReview is happy.
Code documentation: There are next to no inline comments in the code, but the code pretty much documents itself.
Comment #8
luxpaparazzi commentedThanks for telling people about the service with whom your module interacts!
But you should still try elaborating your project page, see:
I'm not convinced hardcoding external web-addresses in your code is a good idea, you should make this modular, so an admin may correct the path if necessary ...
This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.
IMO:
Even that your code is larger as described above I still find it to short for doing a serious evaluation.
Comment #9
luxpaparazzi commentedThe response time for a review is now approaching 4 weeks.
Get a review bonus and we will come back to your application sooner.
See: http://drupal.org/node/1410826
You could for example start by evaluating my own project:
http://drupal.org/node/1302786
Comment #10
klausiClosing due to lack of activity. Feel free to reopen if you are still working on this application.