Add ColorBox to packaging whitelist

There's an important detail here, which we should ideally address in a more general sense:

Some external libraries provide a "latest official stable download URL" in addition to version-specific download URLs.

We should whitelist both URL patterns in that case.

The only problem is that the MIT license isn't listed under the GPL-compatible licenses, even though it seems to be listed on this project's page... I don't know if anyone ever decided whether or not we can include MIT-licensed code? We should probably work on this in #1360456: Finalize the criteria and process for the whitelist for external dependencies packaged with Drupal distributions.

Postponing for now... regex would be:

^http://jacklmoore\.com/colorbox/.+$
^https://github\.com/jackmoore/colorbox/.+$

Usually expat http://www.gnu.org/licenses/license-list.html#Expat
Or X11 http://www.gnu.org/licenses/license-list.html#X11License

Both are referred as MIT and both are gpl compatible.

In this case it is the Expat license.

Sounds good. greggles and somkottler helped clarify in IRC (in #drupal-contribute) as well.

Added ColorBox: http://drupal.org/node/1404260

I need to define a specific revision due to issue #1370196: Drupal 6 jQuery version too old for Colorbox plugin version 1.3.19 and later

but I get the following error message instead:

The library 'colorbox' cannot be downloaded from https://github.com/jackmoore/colorbox.git, the URL must be [error]
in the whitelist available at http://drupal.org/packaging-whitelist.

There are a few libraries failing just like this because the defined RegEx patterns don't allow the download URLs I need to set.

my .make file:

; @see http://drupal.org/node/1370196
libraries[colorbox][download][type] = "git"
libraries[colorbox][download][url] = "https://github.com/jackmoore/colorbox.git"
libraries[colorbox][download][revision] = "7f9bbd64c39d24d2c2c3a3368cc64b86104a0483"
libraries[colorbox][destination] = libraries

I propose we add following pattern to whitelist too:
^https://github\.com/jackmoore/colorbox\.git$

^https://github\.com/jackmoore/colorbox.+$

It works for both URLs:
https://github.com/jackmoore/colorbox.git
https://github.com/jackmoore/colorbox/zipball/master

Updated; post back if you still have any trouble. Thanks for the bug report!

Sorry to open this again.

Thanks for updating the pattern. I tested it locally with Drush 5.0 and it works.

I had the same Colorbox and Superfish white-listing pattern issues, and they both are resolved.

However, I still have issues creating a new distribution release. See #1507376: Packaging error messages

Any ideas?

The whitelist entries look fine, see http://drupal.org/node/1404260

Have you done a drush verify-makefile ? Does it build using drush make?

I'm closing this issue, reopen if you want the URLs changed for some reason.