Other modules would certainly benefit from knowing what kind of headers are currently set. Using drupal_set_header() is identical in functionality other than it keeps a record of the current headers. This one line fix will enable devel module to work with query logging and private file transfers, and will keep it from breaking upload.module, imagefield.module, and others.

Applying to 5.x and 4.7 would be preferable also.

CommentFileSizeAuthor
file_transfer_headers.patch592 bytesquicksketch

Comments

moshe weitzman’s picture

Status: Needs review » Reviewed & tested by the community

trivial, and merits backport IMO.

m3avrck’s picture

Agreed, this one liner should go into HEAD and 5.x :-)

dries’s picture

Version: 6.x-dev » 5.x-dev

Committed to CVS HEAD. Thanks.

drumm’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 5.

Anonymous’s picture

Status: Fixed » Closed (fixed)