I’ve noticed a few missing features but I was curious if you had a list of the differences from Sass.

It would be very useful to know the limitations of this port.

Here’s a few that I ran into so far. If you don’t have a list, I’ll add it here myself as I run into them.

  • @if construct - causes fatal errors
  • mix() color function missing
  • Named arguments in mixins/functions

Comments

richthegeek’s picture

richthegeek commented
Category: bug » feature

We picked up from where the prior maintainers of PHamlP left off, and they stopped updating about a year before we started at least.

As such, there are some differences between this port and the official parser. The fact is, there will /always/ be differences to soem degree as SASS is a parser-defined language.

That said, we are trying to get it up to scratch (and we have a lot of ground to cover, catching up to a moving target).

If you find any more missing features then put them as issues on here or the github page, or chat to me on Skype/IRC directly.

This issue is as good a place as any for a list...

dvessel’s picture

dvessel commented

I understand there will always be differences. It’s knowing what they are and listing their status that would be of great help.

Since it’s specific to the parser, I’ll communicate on the git project page but my time is short. And it looks like issue tracking was turned off. Could you enable it?

I’ll update the list on this page and the details can be sorted out on github.

If anyone finds missing features, please post them here.

richthegeek’s picture

richthegeek commented

Issues on github are now turned on... probably best to keep it here for the moment as it's currently an 100% drupal project.

richthegeek’s picture

richthegeek commented

can you post failing code for @if statements - they have a unit test devoted to them at the moment so work at least in principle - I suspect if you are wrapping them in brackets then they have issues...

dvessel’s picture

dvessel commented

I’ll test it again. This is the first time I’m using Sass so I most likely used it in a wrong way. I’ll post anything I find in a separate issue.

richthegeek’s picture

richthegeek commented

For reference, this test passes without issue (although it is too simple to be a proper test, just that the bare-bones of it works.

richthegeek’s picture

richthegeek commented

God i am le retard, forgot to post link: https://github.com/richthegeek/phamlp/blob/master/tests/if.sass

richthegeek’s picture

richthegeek commented
Status: Active » Postponed (maintainer needs more info)

Latest update to PHamlP fixes issues with the "mix" function. Let me know if it works as expected.

Example: mix(#000, #fff) => #7f7f7f

richthegeek’s picture

richthegeek commented
Status: Postponed (maintainer needs more info) » Closed (fixed)

Named arguments were completed recently. Currently this is marked as closed.

However, please do reopen it again if there are new missing features

richthegeek’s picture

richthegeek commented
Issue summary: View changes

Updated.