This patch hides the Configure fillpdf-service.com section of the Fill PDF settings page except when Use fillpdf-service.com is selected as the PDF-filling service.

CommentFileSizeAuthor
#8 fillpdf_service_config.patch2.01 KBliam morland
#6 fillpdf_service_config.patch1.95 KBliam morland
#4 fillpdf_service_config.patch3.28 KBliam morland
#2 fillpdf_service_config.patch3.01 KBliam morland
fillpdf_service_config.patch3 KBliam morland

Comments

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented

Can you re-roll this patch? It doesn't really show what has changed, and it doesn't apply anymore.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
StatusFileSize
new fillpdf_service_config.patch3.01 KB

Most of the change is change in indentation. Re-roll attached.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented

Sorry, it seems like this needs another re-roll since I've applied the HTTPS patch. To save yourself some trouble, wait until I update #1393012: Default node for a PDF, which I will commit if there are no issues.

patch < fillpdf_service_config_0.patch
patching file fillpdf.admin.inc
Hunk #2 FAILED at 49.
1 out of 2 hunks FAILED -- saving rejects to file fillpdf.admin.inc.rej
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
StatusFileSize
new fillpdf_service_config.patch3.28 KB

Thanks. Reroll attached.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented

Hmm, this isn't quite there yet (it won't hold back the release). Can you use jQuery instead to hide and show the options conditionally? The UX of what we have so far is worse than before because it requires an extra save.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
StatusFileSize
new fillpdf_service_config.patch1.95 KB

Attached is a jQuery-based solution.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Status: Needs review » Needs work

Thanks! Functionally, this does the job. Can you implement it using Drupal.behaviors though? See http://drupal.org/node/756722#behaviors.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Needs review
StatusFileSize
new fillpdf_service_config.patch2.01 KB

Updated patch.

wizonesolutions’s picture

wizonesolutions
he/him
Primary language English
Location Norway
commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Patch (to be ported)

Committed in 1ece86c. Thanks!

  • Commit 1ece86c on 7.x-1.x, 7.x-2.x, 7.x-2.x-tests1, 7.x-1.x-ubercartbackporttest authored by Liam Morland, committed by wizonesolutions: 
    Issue #1404354: Show Fill PDF Service settings when relevant.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Issue summary: View changes
Status: Patch (to be ported) » Closed (fixed)

Drupal 6 is no longer supported.