Needs review
Project:
Spaces
Version:
7.x-3.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Jan 2012 at 22:35 UTC
Updated:
16 Sep 2014 at 19:15 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mrfelton commentedComment #2
chriz001 commentedI had the same problem, however your code didn't work for me.. but i noticed your loading the space based on the object nid.
I changed that to load the space based on the tid associated with that node.
Seems to work for me.
Comment #3
q0rban commentedMarking as major, since this module doesn't even work without this functionality.
Attached patches for 7.x and 6.x. One thing to note on the 7.x patch. I see no reason to check for $type == 'node' anymore, as taxonomy can exist on other entities in 7. If someone disagrees, let me know and I can re-roll.
Comment #4
chriz001 commentedLooks good to me.
Quick question, should we use $object->language instead of LANGUAGE_NONE when we load the space?
they both return 'und' if there is no language.
Im not sure, maybe it doesn't matter :)
Comment #5
finn lewisPatch http://drupal.org/files/spaces_taxonomy-1404586-return-taxonomy-space-3.... in #3 works for me.
But I agree with @chriz001 about the language issue - presumably using LANGUAGE_NONE would prevent this working muli-language content.
Comment #6
euk commented+1
Patch https://www.drupal.org/files/spaces_taxonomy-1404586-return-taxonomy-spa... in #3 works for me as well.
Using:
- Drupal v7.28
- Spaces 7.x-3.0-alpha1
However, if you look at the spaces_taxonomy class (spaces_taxonomy.inc), there is a method space_taxonomy::router, which has very similar piece of code:
I wonder if this method was supposed to switch spaces?
$op='init' is passed when viewing taxonomy. It switches spaces when navigating to something like 'taxonomy/term/56'
$op='node' seems to be never passed to the method.
Cheers!