Hi,
Currently when a user unsubscribes they just see 'Your comment follow-up notification for this post was disabled. Thanks' and the rest of the page is empty. To me, on first reading, this message implied that subscription was already disabled, but that was not the case. Also the user does not see the post they have unsubscribed to, and this can also lead to confusion. If they made a mistake and want to re-subscribe it is better if the node was displayed right there.

I have made a small enhancement so that when the user unsubscribes, they get to see the post they are unsubscribing from, the subject of the comment(s) they made and a message saying 'notification is now turned off' or 'notification was already turned off'. They also get a warning if the hash value did not match up at all, eg they pasted only part of the url.

I will post a patch here for D6 as that is the version I am using. If there is any interest, then I guess it ought to be changed in D7 first.

Jonathan

CommentFileSizeAuthor
#1 _comment_notify.1404990_2.feedback_when_unsubscribing.D6.patch1.98 KBjonathan1055

Comments

jonathan1055’s picture

jonathan1055 commented
Status: Active » Needs review
StatusFileSize
new _comment_notify.1404990_2.feedback_when_unsubscribing.D6.patch1.98 KB

Here is the patch, against 6.x-1.6

Jonathan

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

If there is any interest, then I guess it ought to be changed in D7 first.

I'm definitely interested in this idea - thanks! It could also be worthwhile to make this a confirmation form where people need to click the button to confirm they want to unsubscribe. It seems to be mixed whether a confirmation form is more appropriate or just taking the action.

One critique:

+    drupal_set_message(t('Comment not found for !hash. No action taken.', array('!hash' => $hash)));

That should use the @ placeholder instead of ! to avoid a cross site scripting vulnerability :)

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Version: 6.x-1.6 » 7.x-1.x-dev
Status: Needs review » Needs work

Marking needs work for the confirmation form, ! placeholder issue and to get it into 7.x first.

If you don't feel like you have the time to add the confirmation form, I'd be fine just doing the improvement you've added here. One potential benefit of a confirmation form is that it could have 3 actions:
* Cancel this comment notification
* Cancel all comment notifications to my e-mail address on this thread
* Cancel all comment notifications to my e-mail address from this site

That would help closing out some old feature requests in the module.