Address Field / Country - language of drop-down list of countries

Looking for this as well. Any progress or plans?

+1

translation of country values on node view w/ patch in attachment
(does not changes the dropdown values, only part of fix)

strangely, the list of countries comes from iso.inc
http://api.drupal.org/api/drupal/includes%21iso.inc/function/_country_ge...

where it is already prepended with $t().
this might need another type of fix.

Is there a plan to fix this definately?
It is really a pain that the dropdown list of the countries is not getting translated.

Any updates on this? Really need it

Hello,

i have the same problem on a multilingual site (french/english). The countries list on the node edit page is French. The name of country is french on the view node in english and french pages.

Thanks.

Any plans to fix this? this is really annoying.
I also have the issue in 7.x-1.0-beta5, even when displaying the content, the countries don't get translated.

Any update?

Apart from using #3...

In order to translate the dropdown values, add the following code to the function
function _addressfield_country_options_list($field = NULL, $instance = NULL)
(in addressfield.module)

+  global $language;
+  if($language->language != 'en') {  
+    $countries_aux = Array();
+    foreach($countries as $key => $value) {
+      $countries_aux[$key] = t($value);  
+    }
+    asort($countries_aux);
+    $countries = $countries_aux;
+  }

  return $countries;
}

#12 works for me :P

Manually applying patch works for me on addressfield version 1.0-beta5
Will make a patch for dev version ASAP. Probably this weekend.

@firfin

Waht do you mean? #13 or #3 (the patch file) works for you?

Thanks

hosais

You can't pass a variable for t(), so a real fix would definitely need to be somewhere else.

@bojanz, I works perfectly passing the variable to t() ;-)

Hello estebant,

Thank you for the idea of fix this problem. I just would like to clarify the issue here:

In the API it says
t($text);
, unless the text that the variable holds has been passed through t() elsewhere (e.g., $text is one of several translated literal strings in an array). It is especially important never to call.

I think the countries names has been translated of course, but I am not sure how can I be sure of that. Could you help explain more? Thanks.

hosais

Hello hosais,
I don't know what to respond you. I made this workaround some time ago and it worked well.
And I do not know why it should not do it. You are free to use it or find another solution :)

Hi estebant,

First of all, thank you for your work and I suppose the solution works because the name of countries definitely should be translated already.

However, on the other hand, the t() should not has variable as parameter because the translators need to know What to translate BEFORE the t() is called. If the content is dynamic, how can the translators translate the terms before it is called. That is there is no guarantee the text would be translated correctly every time.

In theory, in my mind (I did not trace the code about how t() is working), I suppose there is no risk in this case. If t() did not find the translation info, it just not translate it. Also in this case there is nothing saved to the database (I mean the address field itself). I mention this because I try to be supportive to clarify the right thing to do. On the other hand, I am very cautious to the patches/code modification since I will put it to my production site.

I really appreciate that you gave me your opinion as a contributor. Thank you again.

hosais

You are welcome mate!

hello,
i am glad having found this thread. problem is, i tried to apply patch #3 in the recent module version 1.2 and the recent dev version also, but this error was thrown out:

Hunk #1 FAILED at 209.
1 out of 1 hunk FAILED -- saving rejects to file addressfield.module.rej

Since i am not coding-savvy, if someone could update the patch, i would be much obliged.

Is this issue old? Because translation works perfectly fine for me out of the box. I'm running this module on an English/German website, and I see the German names of countries when translating content. However, I'm not using core content translation, rather field translation through the Entity Translation module.

Seems to work now.