video and audio types are inverted what breaks the player.
Moreover $raw_files often already contains the type key.

CommentFileSizeAuthor
#4 jplayer-type-detection-1405680-4.patch1.1 KBstevetweeddale
#1 1405680-1-revert-audio-video.patch802 bytesdrzraf

Comments

drzraf’s picture

drzraf commented
StatusFileSize
new 1405680-1-revert-audio-video.patch802 bytes
deviantintegral’s picture

deviantintegral commented
Status: Active » Needs work

Functionally this looks fine, but there are some code style / spacing issues to be cleaned up.

drzraf’s picture

drzraf commented
Status: Needs work » Reviewed & tested by the community

it is not an issue, I encapsulated a block in a if statement thus I generated the commit with diff -w in order to make the change readable.
1 files changed, 13 insertions(+), 11 deletions(-)
1 files changed, 4 insertions(+), 2 deletions(-)

stevetweeddale’s picture

stevetweeddale commented
Assigned: drzraf » Unassigned
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new jplayer-type-detection-1405680-4.patch1.1 KB

Attached a cleaned up version of #1.

stevetweeddale’s picture

stevetweeddale commented

Hold the phone, looks like this has already been fixed in #1192826: Undefined variable: player_type in jplayer_sort_files() in the within the patch in #19. Gah.

deviantintegral’s picture

deviantintegral commented
Status: Needs review » Fixed

Since that patch is still at needs review, I committed this in dafadd3.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.