Using Activemenus in IE, if starting from a first level page, you try to expand two levels of menus, you get a script error and nothing happens.

Steps to reproduce in a typical navigation menu setup:

  1. Expand Administer
  2. Try to expand Logs

Observe that it doesn't expand, and instead you get this script error (replace example.com with your domain):

Line: 54
Character: 17
Code: 0
Error Message: 'length' is null or not an object
URL: http://example.com/

Note that Activemenus continue to work after the script error (though you still can't expand 2nd level nodes).
Note also that if the first level menu was already expanded when you loaded the page, Activemenus will happily load the second level menu. It's only if you dynamically load the first level then second level menu in one go!

Affected browsers: IE6 and IE7
Not affected: Fx1.5, Fx2, Opera9 [though see http://drupal.org/node/140585 re Opera]

Themes tested: Pushbutton, Bluemarine
I was unable to test this with Garland in IE6 or IE7 due to two separate bugs I just filed.

CommentFileSizeAuthor
#2 jstools_support_absolute_path_140620.patch1.3 KBJomel

Comments

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

This problem seems to come from two bugs in IE.

The first is that getAttribute('href') returns the absolute href, not the href that's actually in the code. I've used a workaround, feeding a proprietary Microsoft 2nd argument to getAttribute. So the initially-loaded links work.

The 2nd problem is that when appending content IE seems to rewrite the URLs from relative to absolute. So the workaround doesn't work here--links are always absolute.

I'll have a look at whether we can add support for absolute URLs. Probably need to pass the base_url value.

Jomel’s picture

Jomel commented
StatusFileSize
new jstools_support_absolute_path_140620.patch1.3 KB

Here's a quick fix so getPath supports absolute URIs:

 Drupal.getPath = function (href) {
+  var protocol = window.location.protocol;
+  if (href.substring(0, protocol.length) == protocol) {
+    // 2 is the length of the '//' that normally follows the protocol
+    href = href.substring(href.indexOf('/', protocol.length + 2));
+  }
   // 3 is the length of the '?q=' added to the url without clean urls.
   href = href.substring(Drupal.settings.jstools.basePath.length + (Drupal.settings.jstools.cleanurls ? 0 : 3), href.length);
   var chars = ['#', '?', '&'];

I also took out the proprietary argument to getAttribute which is no longer needed.

It fixes the issue in IE5.5, IE6 and IE7.
I've tested briefly in Fx1.5, Fx2 and Opera9 and can't see any regressions.

I didn't check the other code much, but you might want to update prependPath for parity, I'll leave you to decide.

P.S. Thanks for the quick review of my other patches!
I'm only just starting out with Drupal, so CVS access is still a while off, but thanks for the offer :)

Jomel’s picture

Jomel commented
Status: Active » Needs review
nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Needs review » Fixed

Much appreciated. Applied.

Jomel’s picture

Jomel commented

Thanks. Just a quick note on your comment in the source though:
It doesn't remove (e.g.) "http://", it removes the whole "http://www.example.com"

nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Thanks, fixed. (Moved your code to a new function to enable reuse.)

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
manuj_78’s picture

manuj_78 commented
Status: Closed (fixed) » Active

Setting the code to active as I just tested activemenu and the problem with IE still exists. It works properly in firefox, but with ie7, second level menu does not load when I click on the plus sign.

I am using drupal 5.1 on a VPS