Problem/Motivation

Using the latest dev, when importing JComments it fails to import (or generate) subjects for each comment. This results in minor usability issues, as can be seen by enabling the "Recent Comments" block which will show the imported date for each comment, but fail to provide links to each (no subject). Enabling or Disabling the subject field for comments has no effect, however editing each comment individually causes Drupal to generate a subject (per the norm)

Proposed resolution

Unfortunately I'm not php-savvy enough to write a patch, but my guess would be that Drupal already has some kind of function it calls when submitting a comment without a subject. Perhaps we can simply tap into that. Otherwise, simply generating a subject from a truncated piece of body text would suffice.

-OR-

Importing the subject of comments from JComments would likely be beneficial for some projects.

Remaining tasks

If rootatwc, or another friendly developer could write a patch that would be swell and I would owe them a life-debt =) hehe

User interface changes

An option to import subjects from JComments or simply autogenerate new subjects would be nifty.

API changes

I dont think there would be any.. but I dont really know either =/

Other Thoughts

I hope I filled this out correctly... and THANK YOU for such an awesome module!!

Comments

pdcrane’s picture

It should be noted that I'm importing from a JComments source where the Title (subject) field has been turned off.. So it's possible that this module DOES import subjects if present in the source database.

I haven't tested this on a source where the title field is enabled.

ParisLiakos’s picture

yes the title is being used..if you ave it switched off,what does joomla uses for title instead?
btw thanks for this beatiful issue summary :)

ParisLiakos’s picture

Status: Active » Fixed

i commited a fix for this.try it:)

pdcrane’s picture

Status: Fixed » Needs review

Hi root,

Gave this another whirl and I'm still seeing no subjects for comments =/

Same results as before. No subjects on comments, but when I manually edit each comment it auto-generates per the norm.

Edit: Sorry! I think I hit the wrong status

ParisLiakos’s picture

Status: Needs review » Fixed

i tried this too with the db you sent me and works fine..maybe you tried with an archive that didnt contain my patch?

pdcrane’s picture

I'll do a manual reinstall of the latest tar and try again.

I was also trying to import over-top of a previous import... not sure if that would make a difference.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.