Posted by Taran2l on January 16, 2012 at 11:34am
3 followers
| Project: | Password policy |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Password strength is not translatable and uses D6 string values.
Comments
#1
Patch attached. Please review.
#2
Shouldn't we just be converting this to use Drupal.t() ? I'm not a JS guy, but I don't see this translate method recommended anywhere.
#3
Drupal core user.js file uses the same technique for translation: provide an already translated strings via settings. Don't know why Drupal.t() is not being used in this scenario.
Also, you may notice, that other strings are being transferred to JS in settings too. My patch just follows this pattern.
#4
As long as the patch works, I'm okay with it for now. This module is in serious need of cleanup and that'll probably just wait until 7.x-2.x.
#5
Sorry, I've made a typo in previous patch (Weak and Good messages are mixed up).
Attached fixed version.
#6
This works good to me. Fixed and committed.
http://drupalcode.org/project/password_policy.git/commit/802aa0c
#7
Automatically closed -- issue fixed for 2 weeks with no activity.