Password strength is not translatable and uses D6 string values.

CommentFileSizeAuthor
#5 password_policy-password_strength_message_translation-1406342-5.patch1.83 KBtaran2l
#1 password_policy-password_strength_message_translation-1406342-1.patch1.85 KBtaran2l

Comments

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Status: Active » Needs review
StatusFileSize
new password_policy-password_strength_message_translation-1406342-1.patch1.85 KB

Patch attached. Please review.

erikwebb’s picture

erikwebb commented
Status: Needs review » Needs work

Shouldn't we just be converting this to use Drupal.t() ? I'm not a JS guy, but I don't see this translate method recommended anywhere.

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented

Drupal core user.js file uses the same technique for translation: provide an already translated strings via settings. Don't know why Drupal.t() is not being used in this scenario.

Also, you may notice, that other strings are being transferred to JS in settings too. My patch just follows this pattern.

erikwebb’s picture

erikwebb commented
Status: Needs work » Needs review

As long as the patch works, I'm okay with it for now. This module is in serious need of cleanup and that'll probably just wait until 7.x-2.x.

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
StatusFileSize
new password_policy-password_strength_message_translation-1406342-5.patch1.83 KB

Sorry, I've made a typo in previous patch (Weak and Good messages are mixed up).
Attached fixed version.

erikwebb’s picture

erikwebb commented
Version: 7.x-1.0-beta3 » 7.x-1.x-dev
Status: Needs review » Fixed

This works good to me. Fixed and committed.

http://drupalcode.org/project/password_policy.git/commit/802aa0c

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.