GTranslate will cause HTTPS pages to throw 'some content is unsecure' errors. I am using it on a website with SecurePages. Here is a quick patch to work around that issue.

I think a more ideal solution is to have the Google Service URL set as a variable (translate.google.com) then set the http prefix by looking for $_SERVER['HTTPS_ON'] and/or other HTTPS flags (443, etc), but this will stop the immediate error.

CommentFileSizeAuthor
#3 gtranslate-support-https-1406698-3.patch1.5 KBBarisW
#2 https.jpg193.95 KBericrdb
#1 gtranslate-support-https-1406698-1.patch1.13 KBBarisW
patch_commit_8126c802b032.patch9.54 KBkevinquillen

Comments

BarisW’s picture

BarisW commented
Version: 6.x-1.7 » 7.x-1.7
Status: Active » Needs review
StatusFileSize
new gtranslate-support-https-1406698-1.patch1.13 KB

Here's a D7 version.

ericrdb’s picture

ericrdb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new https.jpg193.95 KB

Patch in #1 worked for me. Thanks

BarisW’s picture

BarisW commented
StatusFileSize
new gtranslate-support-https-1406698-3.patch1.5 KB

Slightly improved version by making it protocol independent.

I had some issues with the block being cached in http and then shown in https, introducing insecure content warnings in browsers. By making it protocol independent, this is not an issue anymore.

Like this:
<script type="text/javascript" src="//translate.google.com/translate_a/element.js" />

BarisW’s picture

BarisW commented
Version: 7.x-1.7 » 7.x-1.9

The patch is against 7.x-1.x-dev by the way.

pcorbett’s picture

pcorbett commented

Tested this in 7.x-1.9 and works well for the on-the-fly method. Might make sense to apply the "//" technique to the rest of the hard-coded urls?

gscerb’s picture

gscerb commented
Issue summary: View changes

I'm using 7.x-1.10 and Drupal 7.32
On my local developmental site "On the Fly" works well.
On my production HTTPS site. Nothing happens in "On the Fly". But "Redirect" will work.
It seems that the secure HTTPS site causes problems.

joshuautley’s picture

joshuautley commented

Running https which is being forced in settings.php file with no module for secure pages, etc.

Patch #3 with on the fly works for us.

Thank you.

alexgreyhead’s picture

alexgreyhead commented

+1 for the patch in 3 - works perfectly :) Thanks :)

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

+1 RTBC

seworthi’s picture

seworthi commented

+1 RTBC, works great.

cammchugh’s picture

cammchugh commented
Status: Reviewed & tested by the community » Closed (fixed)

The protocol relative approach was included in the 7.11 release. Closing this issue as fixed.