Several region templates have double dashes in their names. Camino and several other browsers seem to mis-interpret that as an end comment and cause serious layout damage.

I suggest changing all comments like this:
</section><!-- region--sidebar.tpl -->

to just a single dash like this:
</section><!-- region-sidebar.tpl -->

The user should still understand what section is ending and no breakage occurs in some (lesser used) browsers.

CommentFileSizeAuthor
#2 tpl-comment-1406704.patch1.45 KBechoz

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Priority: Normal » Major

What? Really?

That's fubar. I can't replace "region--sidebar.tpl" with "region-sidebar.tpl" because the double-dash one is the filename. And the filename can't be changed.

Blargh. But the comment does need to be changed. Maybe just use the PHP version of the hook suggestion instead of the filename version? e.g. region__sidebar instead of region--sidebar.tpl. :-\

Who wants to write the patch?

echoz’s picture

echoz commented
Status: Active » Needs review
StatusFileSize
new tpl-comment-1406704.patch1.45 KB
jasondecamp’s picture

jasondecamp commented

I ran into this problem with FF 3.6 which also can't handle the double dash within a comment.

Patch #2 worked for me.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Needs review » Fixed

Thanks, Rad and Elly! You're in the maintainers list now. http://drupal.org/node/88566/committers?sort=asc&order=User

Fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

forgot to wrap code in code tags