Strict warning: Only variables should be passed by reference in custom_pub_admin() (line 44 of /***/custom_pub/custom_pub.admin.inc).

CommentFileSizeAuthor
strict_warning.patch489 bytesdema502

Comments

DeeZone’s picture

DeeZone commented
Title: Strict warning » Strict warning: Only variables should be passed by reference in custom_pub_admin() (line 44
Version: 7.x-1.0-rc1 » 7.x-1.x-dev
Status: Active » Reviewed & tested by the community
Issue tags: +apply.patch

Warning displayed at: /admin/structure/custom_pub

Strict warning: Only variables should be passed by reference in custom_pub_admin() (line 44 of /Users/dee/Sites/runwaypassport.com/pantheon/sites/all/modules/contrib/custom_pub/custom_pub.admin.inc).

Tested with both 7.x-1.x-dev and 7.x-1.x-rc2. it appears this patch didn't make it in 7.x-1.0-rc1 as reported / originally submitted. Reviewed patch code, applied to 7.x-1.x-dev, strict warnings removed / addressed. Please consider adding to latest dev release.

kevinquillen’s picture

kevinquillen commented

What version is this? I am not seeing this in what I just cloned from the project in custom_pub.admin.inc. Line 44 for me has:

return $table . render(drupal_get_form('custom_pub_add'));

Did I miss something?

kevinquillen’s picture

kevinquillen commented
Status: Reviewed & tested by the community » Fixed

My bad, my IDE was stuck on the master branch and not 7.x-1.x. A restart corrected this and I have committed this into dev. Thank you.

Automatically closed -- issue fixed for 2 weeks with no activity.