As the settings components aren't required, you get a bunch of PHP notices when not filling that info.

Patch attached

CommentFileSizeAuthor
commerce_bank_transfer-avoid_notices_checkout.patch2.37 KBpcambra

Comments

checker’s picture

checker commented

Works for me

xibun’s picture

xibun commented
Status: Needs review » Fixed

nice catch. thanks. committed to dev.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

Terrific, please consider proper git attribution for future patches :)

xibun’s picture

xibun commented

actually I came across that page just by chance yesterday.. but I saw it's not possible to attribute several authors - so I drop it for consistency's sake until that's possible.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

Well, I think you're supposed to evaluate who the main contributor of the patch is and assign the authorship to that person, I agree that there's a lack of support for multiple authors but in issues like this one it's quite easy.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.