Fatal error when disabling Multilink Filter module [#1407304]

Steps I did:

Enable Multilink and Multilink Filter modules
Add the Multilink filter to a text format
Disable the Multilink Filter module

But, you should be able to reproduce by *only* enabling Multilink by itself.

Error:

Fatal error: Call to undefined function _multilink_filter_default_settings() in /var/www/i18n/sites/all/modules/contrib/multilink/multilink.module on line 326

It is not easy to recover from the error, even by manually by disabling the Multilink module or enabling the Multilink Filter module back on via the database (because their statuses are cached). You can remove the multilink directory completely from the modules directory though.

The fix is to check that the function exists before calling it since the Multilink module is not dependent on the Multilink Filter module. Patch is attached. The alternative is to make the modules dependent on each other.

Comment	File	Size	Author
	multilink.module.patch	403 bytes	kristen pol

Comments

Comment #1

andy inman commented 19 January 2012 at 10:51

Thanks for that - I obviously missed it when coding the D7 version (in D6 the core and filter functionality were in the same module.) Your patch will fix it, but looking at the code I can see it would be better to restructure to keep the default settings in the relevant module only.