This module saves the path directory in the database, including sites/[sitename]/files/... Changing the site from default to multisite and from dev to live in an OTAP environment breaks the path for the menu icons. It would be more robust to use the Drupal 7 file API instead (http://drupal.org/node/555118).
Or, as imagecache is in core now, we could completely rely on imagecache handling of the images that make use of the file API.

Comments

acrollet’s picture

acrollet commented
Priority: Normal » Major

I agree, this would also fix #1399516: Icons disappear after update - patches accepted of course, but I'll try and work on this when I get a chance.

acrollet’s picture

acrollet commented
Issue tags: +D7 stable release blocker

tagging.

hanno’s picture

hanno commented

Good to hear! As imagecache is completely in core, we could make this module dependent on the core 'image' module. That would make sense I think. If so, we could remove code and if-statements.

acrollet’s picture

acrollet commented
Status: Active » Fixed

Committed these changes in http://drupalcode.org/project/menu_icons.git/commit/2a87da8 - I would greatly appreciate a review. I'd like to hear back if this code is working well, and will roll another beta once I've heard something.

Automatically closed -- issue fixed for 2 weeks with no activity.