I downloaded:

; Information added by drupal.org packaging script on 2011-12-19
version = "6.x-3.1"
core = "6.x"
project = "gigya"
datestamp = "1324280741"

And tried to set up an action of "Share comment via Gigya" (may not be the exact words, as I'm recalling from memory). Then I set up a trigger to call that action upon saving a new comment. It didn't work.

Upon looking into it I found in gigya_shareui_js you the drupal_add_js commented out. I uncommented, but I got a JS error. That was because in gigya.behaviors.js you were calling Drupal.gigya.showShareUI(Drupal.settings.gigya.shareUIParams); howver shareUIParams is an array, not an object. Plus I commented out the $('#btnShare').click( function (e) { part, as the system was no longer triggering the share based on this single button. This seemed pretty safe, as the only place it was referenced was in the gigya_link function that was already commented out. That being said, I don't know if this has broken other things (like node sharing) as I am still testing these fixes.

In general I have found commented out, unfinished, and out right broken code. In addition, it would be great if the embedded widgets (on the register and login forms) were optional and configurable. So we could set them to show up above, below, or not at all independently for each form. Also it would be cool to provide Drupal integrated sharing of nodes and comments through hook_link (it looks like you have a commented out start), instead of forcing the user to use the full share bar or gigya comments. That way if they don't want the full blown solution, but instead a more Drupal integrated solution, you can provide that as an option.

I haven't had a whole lot of time to audit the code, so I may have missed things and/or misunderstood thing, but that should give you enough information to start the audit process yourself.

CommentFileSizeAuthor
#1 1407960-fix-action-js-1.diff4.51 KBrwohleb

Comments

rwohleb’s picture

Status: Active » Needs review
StatusFileSize
new4.51 KB

I've written a patch that gets things working for me. I've tested it with a rule created against comment creation. I also add a snippet that tried to find an open graph image meta tag before it tried to find an image in the content. This way it will integrate better with Facebook and such.

rwohleb’s picture

Still no movement on this?

Gigya’s picture

Status: Needs review » Closed (won't fix)

Gigya's 6.x module is deprecated. We no longer support this version and we encourage upgrading to our latest module.