Port check wrong for URL with credentials [#1408190]

The regexp introduced in by #1388916: Bad port validator in d222449 doesn't work for URLs that includes credentials, which can be of the form

In this case, the regexp matches 'password@host:url' and 'password@host' respectively, and those obviously aren't integers.

Comment	File	Size	Author
#3	1408190-2-test-only.patch	1.54 KB	DeFr
#3	1408190-2-test-and-fix.patch	2.79 KB	DeFr
#1	bug-1408190-by-DeFr-Fix-port-check-for-url-with-cred.patch	1.27 KB	DeFr

Comments

Comment #1

DeFr commented 18 January 2012 at 18:36

Status:

Active

» Needs review

Status	File	Size
new	bug-1408190-by-DeFr-Fix-port-check-for-url-with-cred.patch	1.27 KB

Attaching a patch that seems to fix it here, by checking if parse_url found a user or not and using a different regular expression if it did.

Comment #2

nick_vh

he/him

Ghent

commented 18 January 2012 at 21:00

Would you be able to enrich this with a simpletest? So it will never fail anymore in the future?

Comment #3

DeFr commented 20 January 2012 at 14:20

Status	File	Size
new	1408190-2-test-and-fix.patch	2.79 KB
new	1408190-2-test-only.patch	1.54 KB

There you go, attaching first the test only that should fail, and then a combined test + patch that should come back green.

Not sure why I'm getting two unrelated failures locally that don't seem to happen with the test bot, were apachesolr.index.inc get added when it shouldn't.