Easier to see what's changed; numeric keys change so 4 => 'admin' may be one export, whereas 5 => 'admin' the next, so looks like 'admin' has changed in some way when hasn't.

Helps when using version control/diff tools

CommentFileSizeAuthor
#8 features_export_keys-1408496-8.patch1.16 KBhefox
#4 1408496.4-features-permission-role-key.patch667 bytesmrfelton
#1 features_role_key.patch686 byteshefox

Comments

hefox’s picture

hefox commented
Status: Active » Needs review
StatusFileSize
new features_role_key.patch686 bytes
mpotter’s picture

mpotter commented

Is this still an issue? Wondering how the import/revert works if you are changing from a numeric to a role name. If this is still valid, let me know and I'll commit it.

mrfelton’s picture

mrfelton commented

Yeah, I think this is still an issue. The array keys are not used so changing from a numerical index to a role name shouldn't have any adverse affect, but it should help stop making things look like they have changes when infact they haven't.

mrfelton’s picture

mrfelton commented
StatusFileSize
new 1408496.4-features-permission-role-key.patch667 bytes

This is a really annoying problem, with a pretty simple fix. Patch updated against latest codebase.

hefox’s picture

hefox commented
Status: Needs review » Reviewed & tested by the community
mpotter’s picture

mpotter commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed in 99e3497.

hefox’s picture

hefox commented

I'm so going to work on backporting this. Yay!

hefox’s picture

hefox commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new features_export_keys-1408496-8.patch1.16 KB

Changes user permissions and formats (wasn't relavent in d7 since formats use permissions instead)

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Bump for testbot.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Reviewed & tested by the community

RTBC, forgot that testbot doesn't work on D6.

hefox’s picture

hefox commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.