Categorized Content Menu

Hi there,

You have some coding standards issues, you could check them out here: http://ventral.org/pareview/httpgitdrupalorgsandboxzenmaster1409284git

You work in the master branch, you should not do that, you should work in 7.x-1.x, more about branching here: http://drupal.org/node/1015226.

There are still two errors:

FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
528 | ERROR | Whitespace found at end of line
530 | ERROR | Use "elseif" in place of "else if"
--------------------------------------------------------------------------------

http://ventral.org/pareview/httpgitdrupalorgsandboxzenmaster1409284git

It could take week or months to have a in depth review, usually we modules there are last in the queue is reviewed first (my own sandbox project have been in queue for a while... but I thought If I help out with code standards reviews, maybe someone else have the time to do in depth reviews :-))

You could user tools like coder and coder tough love locally without having to install cygwin or similar. But you should do you development work in a separate branch (dev), and that you could commit to and use the PAReview.sh script online on just that branch.

I did a manual review of your module and i notice that the variables need to be fully sanitized.

1. use check_plain and check_markup functions for the variables
2. use check_url functions wherever you are returning url
3. use translate functions t() in hook_help

Good, you still have a couple of coding standards issues:

10 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
52 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."
82 | WARNING | Format should be "* Implements hook_foo()." or "Implements
| | hook_foo_BAR_ID_bar() for xyz_bar."

You have included images, where do they come from, is your own work?

I will try to do a manual review later this week if no one else do it fist.

It is really a complex module, and it is going to take some time to review it. I start of some small things...

ccm.install

You module seems to be dependent on the vocabulary Categorie, what if the user wants to use another vocabulary, or already uses a vocabulary with that name in another context?

You also create a field on install, field_ccm_categorie, I think it should be better if the the users could define which field they want to use

ccm.module

ccm_uninstall() should be in ccm.install, not ccm.module

More later on...

(You seem to have good documented code, that is going to do the job easier :-))

Continue...

Git branch

The branch name 7.x-1.x-dev is not correct, you should remove or rename it. See http://drupal.org/node/1015226

Images

I am not sure if you could include the images, Visual Pharm has another license than Drupal has, and Ajaxload do not specify which license the images have. But that is more than I know....

All variables should have unistall function

You define a couple of variables, they should have the possibility to be unistalled

I installed the module and tried to add paths for my content types, without luck...

Dev should be used for your own work - not the work you have for review - that should be in 7.x-1.x.

It is no problem to close this application and open another one.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

url changed