mailhandler update 6207 has changed the 'Body' (origbody) importer mapping source to 'Body (HTML)' (body_html).

However, mailcomment continues to use the 'origbody' in multiple places in mailcomment.module and mailcomment_default/mailcomment_default.feeds_importer_default.inc

 $grep -R origbody *
mailcomment_default/mailcomment_default.feeds_importer_default.inc:61:            'source' => 'origbody',
mailcomment.module:454:  $identifier = _mailcomment_get_signature(rawurldecode($item['origbody']));
mailcomment.module:555:        $message['origbody'] = _mailcomment_filter_basic($message['origbody']);
mailcomment.module:560:        $message['origbody'] = _mailcomment_filter_aggressive($message['origbody']);
plugins/authenticate_plugin/MailcommentAuthenticate.class.php:15:    $identifier = _mailcomment_get_signature(rawurldecode($message['origbody']));

I think this can be fixed by changing each instance of origbody to body_html.

CommentFileSizeAuthor
#1 1409678-mailcomment.patch3.06 KBpereljon

Comments

pereljon’s picture

Status: Active » Needs review
StatusFileSize
new3.06 KB

Nice. I was seeing a lot of origbody index errors in my log. I'm attaching a patch for your proposed fix.

danepowell’s picture

Status: Needs review » Fixed

Doh... thanks for the catch and patch.

http://drupalcode.org/project/mailcomment.git/commit/e97e928
http://drupalcode.org/project/mailcomment.git/commit/44646e5

I've added an issue to create some simpletests to make this sort of thing less likely in the future.... #1410436: Simpletests

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

gaëlg’s picture

This prevents the current stable release from working correctly. A new one might be released?

danepowell’s picture

No problem, see the 2.2 releases.

gaëlg’s picture

Thanks!