Closed (fixed)
Project:
Quickstats
Version:
5.x-1.0
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
3 May 2007 at 12:13 UTC
Updated:
19 May 2007 at 18:30 UTC
There is a very small error in the SQL code which prevents the module from functioning correctly. In quickstats.module change this line:
db_query("SET @s = CONCAT('DELETE FROM quickstats_views WHERE nid IN (', @ids, ')')");
to this:
db_query("SET @s = CONCAT('DELETE FROM {quickstats_node_views} WHERE nid IN (', @ids, ')')");
Since it's only one line, I think it's useless to post a patch.
Apart from this tiny glitch, this module works great! Thanks, chx! :)
Comments
Comment #1
FiReaNGeL commentedThe error has been fixed in the dev version since the 22nd of April, but apparently (due to my inexperience with cvs), I didn't upload the modification to the 1.0 version.
I will release a 1.1 version overweekend that fix this bug along with a less obvious one (currently, the module breaks cached pages, as we are calling drupal_get_normal_path but the cached pages do not include path.inc. I'll probably add an additional mysql check before the update, to make sure there's something to update, to get rid of the db error / watchdog call when there is no pageviews since the last cron (could happen at slow periods on a frequent cron website).
My girlfriend is moving in the appartment this weekend so all this could be delayed, but not much :)
Comment #2
FiReaNGeL commentedThis should be fixed (as well as some other minor problems) in the latest 1.1 version. Thanks for the report :)
Comment #3
FiReaNGeL commentedComment #4
(not verified) commented