line 224 of the addressfield.module file

      if (isset($child['#prefix'])) {
        $child['#prefix'] = (isset($child['#prefix']) ? $child['#prefix'] : '') . $child['#prefix'];
      }

First of all that second "isset" can never return false so the statement isn't really necessary but most importantly if the prefix exists you always end you with two of them.

This means my addresses look like:
Starbucks, , 237 West Pender Street, , Vancouver, , BC

CommentFileSizeAuthor
#6 addressfield-double-space.patch776 bytesnodestroy
#5 duplicate-prefix-1410612-5.patch754 bytespeterpoe
#4 duplicate-prefix-1410612-4.patch700 bytespeterpoe
#1 addressfield-doubleprefix-1410612.patch692 bytesraychaser

Comments

raychaser’s picture

raychaser commented
StatusFileSize
new addressfield-doubleprefix-1410612.patch692 bytes

Here's a patch. This is my first drupal patch so let me know if I'm doing it wrong.

petsagouris’s picture

petsagouris commented
Status: Active » Needs review
cosmicdreams’s picture

cosmicdreams commented
Status: Needs review » Reviewed & tested by the community

Works awesomely

peterpoe’s picture

peterpoe commented
Version: 7.x-1.0-beta2 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new duplicate-prefix-1410612-4.patch700 bytes

The patch in #1 removes any #field_prefix. This should be a proper fix.

peterpoe’s picture

peterpoe commented
StatusFileSize
new duplicate-prefix-1410612-5.patch754 bytes

Ops, forgot to change one line.

nodestroy’s picture

nodestroy commented
StatusFileSize
new addressfield-double-space.patch776 bytes

i think there is something broken with your last patch. attached another version.

dasjo’s picture

dasjo
he/him
Primary language German
Location Zurich
commented
Status: Needs review » Reviewed & tested by the community

patch in #6 works just fine and fixes the problem.

chaby’s picture

chaby commented

Thanks, seems that #5 is a better approach than #6 if you want to add #field_prefix property to the element, and want to suffix #prefix with it...
Anyway, maybe #field_prefix and #field_suffix aren't really usefull as most of the time, you could simply aggregate it into #prefix or #suffix directly (or override other elements) ... ?

johnv’s picture

johnv
Primary language Dutch
commented
Status: Reviewed & tested by the community » Needs review

There seems to be some dispute on the correct versions: #5 or #6, so I set the status back.

Also, #1232608: Don't duplicate addressfield element prefixes or use non-breaking space prefixes for inline elements contains the same patch and more, and has bigger audience. Should this issue be set as dulicate?

Garrett Albright’s picture

Garrett Albright commented
Status: Needs review » Closed (duplicate)

I would say so. Marking as dupe of #1232608: Don't duplicate addressfield element prefixes or use non-breaking space prefixes for inline elements.