Download & Extend
Issues

comment_post patch

Posted by joshk on December 8, 2004 at 10:31pm
Project:Drupal core
Component:comment.module
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Attached is a patch which fixes the problems with comment.module and mailhandler. It replicates comment_post() in mailhandler (as mailhandler_comment_post), nixing the drupal_gotos at the end of comment_post so that it can be auto run by cron without stopping.

Also fixed a minor SQL bug (missing comma on line 535).

AttachmentSizeStatusTest resultOperations
mailhandler_0.patch9.31 KBIgnored: Check issue status.NoneNone
Login or register to post comments

Comments

#1

Posted by joshk on December 8, 2004 at 10:37pm

Here's a patchfile that's not backwards.

AttachmentSizeStatusTest resultOperations
mailhandler_corrected.patch9.31 KBIgnored: Check issue status.NoneNone

#2

Posted by moshe weitzman on December 8, 2004 at 10:46pm

please submit a patch to comment_post instead. We don't want to maintain all that comment code in mailhandler

#3

Posted by killes@www.drop.org on December 8, 2004 at 10:48pm

The problem is that mailhandler and listhandler are broken for 4.5 without this patch. Even if we would convince Dries to accept a patch to comment.module for the 4.5 branch our module swould be unusable until the release of 4.5.2.

#4

Posted by moshe weitzman on December 8, 2004 at 10:51pm

ok. then someone is welcome to check this code into 4.5 branch. please don't check it into HEAD. Instead, refactor comment_post()

#5

Posted by Steve Dondley on January 28, 2005 at 11:05am

You don't know how many hours of my life I lost trying to get mailhandler/listhandler to work. I ended up tracking it down to this bug (which I didn't know about until now). I came here to post my own patch for it.

Can some PLEASE put a note in the INSTALL.txt file to use this patch? It will save other people the nightmare I went through. I spent countless hours trying to figure out what was wrong with my mail list settings/mailhandler settings before I figured out it was a bug.

Again, please, for other people, make a note in the INSTALL file about this patch.

#6

Posted by Steve Dondley on January 28, 2005 at 11:47am

NOTE: Hunk 3 failed on latest version of mailhandler.module.

#7

Posted by handelaar on February 6, 2005 at 2:59am

Yeah, he's not wrong.

The patch fails.

#8

Posted by drumm on February 9, 2005 at 1:38am
Assigned to:joshk» drumm

I will be testing and committing this as instructed in update #4.

#9

Posted by drumm on February 9, 2005 at 7:35pm
Project:Mailhandler» Drupal core
Component:Code» comment.module
Category:bug report» task
Assigned to:drumm» Anonymous

Committed to 4.5.

Now who is going to fix it in CVS before 4.6?

Sumary: comment_post uses drupal_goto() which horrilbly confuses any module which tries to post comments programmatically.

#10

Posted by moshe weitzman on July 26, 2005 at 6:22pm
Status:active» fixed

#11

Posted by Anonymous on August 9, 2005 at 9:47pm

#12

Posted by Anonymous on August 23, 2005 at 10:00pm

#13

Posted by Anonymous on September 6, 2005 at 10:20pm

#14

Posted by Anonymous on September 20, 2005 at 10:40pm

#15

Posted by Anonymous on October 4, 2005 at 11:00pm
Status:fixed» closed (fixed)
nobody click here