Yesterday panels had an update, so through Drupal's admin i update panels and it killed a clients site. This was in no way a fault of panels but my own because my custom styles was stored in the panels folder (yes shame on me :P). When panels doesn't find a style it kill the style, content and all else.

Is there possibly a way to have panels (ie panels everywhere site template) to run a check and if it doesn't see the style to revert to no style?
So instead of a missing style rendering no content, a missing style is removed/ignored and the content still shows?

Thanks,
Draven

Comments

Letharion’s picture

Letharion commented
Version: 7.x-3.0-alpha3 » 7.x-3.x-dev

merlin may have a different opinion, but personally, I want Panels, and various other modules, to keep to the settings I've given it.
I've done similar mistakes myself, several times, but I still don't like the idea of "making excuses for bad practice".

For example, I recently had a View, that depended on a views extension module. I accidently imported the View, without enabling the extension module, and so my View broke down. If Views then tried to be "intelligent" about it, it could have changed my settings in a way that 1) made it harder for me to find the problem, since there is no "problem" anymore, and 2) delay the discovery of the issue completely, since the view might "sort of" work.

Draven_Caine’s picture

Draven_Caine commented

Well, panels could "disable" the style and have a message on the panels page saying "missing style". More of what I was meaning was if the style is missing that means the tpl file is missing and no "print content" varible and that means no content. cant we just make it use a standard tpl file as a fall-back fail safe?

Now if we take this not just to a style issue but to a panels everywhere issue this almost locks your site as panels style prints your main page content, which you need in order to fix said problem.
I understand your point, but it would make it much easier if you did mess up a style which was on the main page content to be able to see the content in-order to get back into panels to fix your mistake, or even get into performance to be able to flush the cache(if the cache is the issue).

Another option also is a checkbox setting in panels /shrug

merlinofchaos’s picture

merlinofchaos commented

It's worth thinking about doing that. We have to fail in a way that's meaningful.

I hope you were able to recover your styles!

Draven_Caine’s picture

Draven_Caine commented

Nope all 3 styles are gone but my mistake.

My main concern was the main content was placed in a style, and no style means no content. So i had to do some database-ing to get back into panels and cache clearing. For someone like me that isnt very good with sql queries, its kinda bad.

seandunaway’s picture

seandunaway commented
Category: feature » bug

+1

I just ran into this issue of accidentally disabling a module that provided the styles. It gave me a WSOD on my panels everywhere install. It took me a while to figure out what caused it as I disabled/enabled a bunch of modules together.

This could really confuse users and I think some kind of fail safe or at least a set message would be helpful.

Interestingly, I tried to disable every occurrence of the style being used by setting to default style via the UI, and still, it was somehow referencing the deleted styles.

I had to export the view, delete the style declaration as well as several lines for every pane that was a child of the pane with the style.

on the panel where i set it:

  $pane->style = array(
    'settings' => array(
      'mystyle' => 'nav',
      'content_id' => '',
      'content_class' => '',
      'title_tag' => 'h3',
      'title_class' => '',
    ),
    'style' => 'mystyle',
  );

and on each children pane???

$pane->style = array(
    'settings' => array(),
    'style' => 'mystyle',
  );
seandunaway’s picture

seandunaway commented

Potentially relevant/duplicate: #1334574: Panel Content Not Showing

japerry’s picture

japerry
Location KOMK
commented
Issue summary: View changes
Status: Active » Closed (outdated)

Drupal 7 is no longer supported, closing.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.