Comments

wmostrey’s picture

Category: feature » task

I don't have any plans to create or maintain a D6 version but the code is simple enough to port. If someone is willing to port and support the release, I'd be happy to add it.

wmostrey’s picture

Category: task » feature
Status: Active » Postponed

Postponing until someone comes forward with a patch.

HS’s picture

Subscribing

sawtell’s picture

Status: Postponed » Active

I have a backport to Drupal 6 of this module.
How do I submit it as a patch?

wmostrey’s picture

There's a file upload element below the comment field labeled "Attach new file". You can add the patch there.

sawtell’s picture

StatusFileSize
new18.35 KB

Thanks, I've attached a patch, hopefully it doesn't need any further work - let me know.

parrot’s picture

does not apply (this for .dev)

facebook_comments parrot$ patch --dry-run  < facebook_comments-D6_version-1411904.patch
patching file facebook_comments.info
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file facebook_comments.info.rej
patching file facebook_comments.install
patching file facebook_comments.module
Hunk #3 FAILED at 26.
Hunk #4 FAILED at 63.
Hunk #5 FAILED at 113.
Hunk #6 FAILED at 297.
4 out of 6 hunks FAILED -- saving rejects to file facebook_comments.module.rej

this for 7.x-1.0-beta2

facebook_comments parrot$ patch  < facebook_comments-D6_version-1411904.patch
patching file facebook_comments.info
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file facebook_comments.info.rej
patching file facebook_comments.install
patching file facebook_comments.module
Hunk #3 FAILED at 26.
Hunk #4 FAILED at 63.
Hunk #5 FAILED at 113.
Hunk #6 FAILED at 297.
4 out of 6 hunks FAILED -- saving rejects to file facebook_comments.module.rej
rickyd1’s picture

StatusFileSize
new14.82 KB

Hi Everyone,

I could not get the patch to run. However, I went through and manually merged and updated the module based on this patch. I have attached a zip file for anyone looking to use this on D6.

A Few notes about this version:

It seems to run fine. However, when I first installed it the comments would not show up. This is because I was using the Facebook Share module. There is a conflict with the Javascript. I believe they are loading the same JS which is causing the errors.

Therefore, I removed Facebook Share button and it is working fine. I am going to test it with the Share This module. If there are any issue, I will report them back here. If you attempt to use this and it does not work, please try removing other Facebook tools.

I did not code this I only merged it from Is206's patch. If you have any issues I will try to help though.

Thanks

wmostrey’s picture

Status: Active » Needs work

Could someone reroll the patch for the latest dev version?

rickyd1’s picture

StatusFileSize
new19.1 KB

I used the modification in the zip file I upload the other day to create this patch. If you run it on the dev, it will fail on the info file. I am new patches, but I followed the instructions. It works on the git repository. I believe this is because the repository does not have the package information provided by Drupal.

If you want to use this with the latest dev, delete

; Information added by drupal.org packaging script on 2012-06-25
version = "7.x-1.0-beta2+5-dev"
core = "7.x"
project = "facebook_comments"
datestamp = "1340626544"

from the info file first. If someone knows a way around this please let me know and I will update the patch.

Thanks

sawtell’s picture

Status: Needs work » Needs review
StatusFileSize
new20.67 KB

Sorry for the invalid patch, hopefully this next one will work.

I have made some slight changes to the code after testing showed some bugs.

If not, here's what I did incase someone can spot where I've gone wrong:
> git clone --branch 7.x-1.x http://git.drupal.org/project/facebook_comments.git
replaced all files with the drupal 6 versions (.info, .install and .module)
> git diff > facebook_comments-D6_port-1411904-11.patch

floydm’s picture

I did a quick D6 port of this module too before noticing this thread. I took the super lazy approach and just required DBTNG rather than rewrite the database queries.

Attached is a patch generated using the same method as comment #11's patch, as well as the module itself.

wmostrey’s picture

Issue summary: View changes
Status: Needs review » Fixed

I'm marking this as fixed for future reference. We won't support a Drupal 6 version as per Drupal 6 end-of-life announcement.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.