Fixed.
PLease review the patch.

CommentFileSizeAuthor
#2 uc_product-1412286-Fix-undefined-variable.patch685 bytesPatchRanger
uc_products_fix_undefined_variable.patch278 bytesPatchRanger

Comments

Status: Needs review » Needs work

The last submitted patch, uc_products_fix_undefined_variable.patch, failed testing.

PatchRanger’s picture

PatchRanger commented
StatusFileSize
new uc_product-1412286-Fix-undefined-variable.patch685 bytes

I've created the patch, that is in Git-format.
Please review.

PatchRanger’s picture

PatchRanger commented
Status: Needs work » Needs review
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Postponed (maintainer needs more info)

How did you get this error in the first place?

PatchRanger’s picture

PatchRanger commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)

It was just a notice, not an error.
Trying to reproduce I have just found that the problem was in another module.
It was sending strange parameter to function uc_product_is_product, that makes notice to appear at every page where any product is.
Sorry for worry.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

This probably should be fixed better in #753964: use is_numeric, not is_int in uc_product_is_product().

camilohollanda’s picture

camilohollanda commented
Version: 6.x-2.x-dev » 7.x-3.4

Fixed manually finding this line and modifyng