Before two weeks I have adopted a trace module to work on Drupal5.x, and after some usage I can say it works pretty well.
So here's a patch.

P.S.
The modifications are done in a way to change the old module code as little as possible

CommentFileSizeAuthor
trace.patch2.64 KBfedot-1

Comments

hass’s picture

hass commented
Status: Needs review » Needs work

.info have wrong version number

hass’s picture

hass commented

PHP Fatal error: Call to undefined function drupal_get_path_alias() in C:\Inetpub\wwwroot\drupal5-test\sites\all\modules\trace\trace.module on line 148

hass’s picture

hass commented

i cannot trace anything if i'm an anonymous user... and i must trace a problem as anonymous users and normal caching enabled :-(((

fedot-1’s picture

fedot-1 commented

1. This patch isn't applied on the .info file... You can make the changes if you want so...
2. If you have no drupal_get_path_alias() you're in trouble, cause it's in drupal core (includes/path.inc)
3. Sure you can trace the drupal as anonymous user! You have to configure module at least once, it's not start tracing before you say what you want to trace.

hass’s picture

hass commented

2. i have core installed and therefor i have drupal_get_path_alias(), but trace seems to be loaded before core and therefor it is not available - this happen ONLY as "anonymous user". as logged in user i can trace whatever i'd like, but this won't help me, while i have a caching issue that can only be reproduced as anonymous user.

3. i think i have configured everything and saved and so on. As normal admin user there is no problem at all.

Arto’s picture

Arto commented
Title: Trace on Drupal5.x » Drupal 5.x branch
Category: support » feature
Priority: Normal » Critical

Fedot, thanks for the patch. I will roll out 5.x-1.0 shortly.

Alexander, once the 5.x version is available, please give that a try. If you still experience the same problem, please open a separate support issue.

Arto’s picture

Arto commented
Assigned: Unassigned » Arto
hass’s picture

hass commented

please create a 5.x-dev release first and let us test... the above patch is not working as written. After testing and if all works well, release. Don't release buggy version :-).

Arto’s picture

Arto commented

Well, the 5.x release will not based directly on the patch, but rather the existing 4.7.x-1.0 version which has had a lot of improvements since this patch was rolled. I intend to maintain version number parity between 4.7.x and 5.x, so if a problem like described above exists it will necessitate an update to both 4.7 and 5.x. I have not experienced the problem with 4.7.x-1.0, however.

Arto’s picture

Arto commented

There is now a 5.x version in CVS. An automated 5.x-dev snapshot should be available in about 12 hours.

I intend to release 5.x-1.0 within the next couple of days.

hass’s picture

hass commented

Are you working on a D6 version, too? :-)))

Arto’s picture

Arto commented

Yes :-)

hass’s picture

hass commented

I hope to see a 6.x-dev build soon :-)

Arto’s picture

Arto commented
Status: Needs work » Fixed

5.x-1.0 has now been released.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
mykle’s picture

mykle commented
Version: 4.7.x-1.x-dev » 5.x-1.0
Status: Closed (fixed) » Active

Still seeing the issue as originally reported in trace 5.x-1.0 and drupal 5.3:

Fatal error: Call to undefined function drupal_get_path_alias() in /home/mykle/mun3/www/modules/trace/trace.module on line 153

Arto’s picture

Arto commented

This is a core function and should always be available:

http://api.drupal.org/api/function/drupal_get_path_alias/5

The only thing I can think of is to check whether you in fact have the Path module enabled?

Arto’s picture

Arto commented
Priority: Critical » Normal
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.