Download & Extend

Drupal 5.x branch

Project:Trace
Version:5.x-1.0
Component:Compatibility
Category:feature request
Priority:normal
Assigned:Arto
Status:closed (fixed)

Issue Summary

Before two weeks I have adopted a trace module to work on Drupal5.x, and after some usage I can say it works pretty well.
So here's a patch.

P.S.
The modifications are done in a way to change the old module code as little as possible

AttachmentSize
trace.patch2.64 KB

Comments

#1

Status:needs review» needs work

.info have wrong version number

#2

PHP Fatal error: Call to undefined function drupal_get_path_alias() in C:\Inetpub\wwwroot\drupal5-test\sites\all\modules\trace\trace.module on line 148

#3

i cannot trace anything if i'm an anonymous user... and i must trace a problem as anonymous users and normal caching enabled :-(((

#4

1. This patch isn't applied on the .info file... You can make the changes if you want so...
2. If you have no drupal_get_path_alias() you're in trouble, cause it's in drupal core (includes/path.inc)
3. Sure you can trace the drupal as anonymous user! You have to configure module at least once, it's not start tracing before you say what you want to trace.

#5

2. i have core installed and therefor i have drupal_get_path_alias(), but trace seems to be loaded before core and therefor it is not available - this happen ONLY as "anonymous user". as logged in user i can trace whatever i'd like, but this won't help me, while i have a caching issue that can only be reproduced as anonymous user.

3. i think i have configured everything and saved and so on. As normal admin user there is no problem at all.

#6

Title:Trace on Drupal5.x» Drupal 5.x branch
Category:support request» feature request
Priority:normal» critical

Fedot, thanks for the patch. I will roll out 5.x-1.0 shortly.

Alexander, once the 5.x version is available, please give that a try. If you still experience the same problem, please open a separate support issue.

#7

Assigned to:Anonymous» Arto

#8

please create a 5.x-dev release first and let us test... the above patch is not working as written. After testing and if all works well, release. Don't release buggy version :-).

#9

Well, the 5.x release will not based directly on the patch, but rather the existing 4.7.x-1.0 version which has had a lot of improvements since this patch was rolled. I intend to maintain version number parity between 4.7.x and 5.x, so if a problem like described above exists it will necessitate an update to both 4.7 and 5.x. I have not experienced the problem with 4.7.x-1.0, however.

#10

There is now a 5.x version in CVS. An automated 5.x-dev snapshot should be available in about 12 hours.

I intend to release 5.x-1.0 within the next couple of days.

#11

Are you working on a D6 version, too? :-)))

#12

Yes :-)

#13

I hope to see a 6.x-dev build soon :-)

#14

Status:needs work» fixed

5.x-1.0 has now been released.

#15

Status:fixed» closed (fixed)

#16

Version:4.7.x-1.x-dev» 5.x-1.0
Status:closed (fixed)» active

Still seeing the issue as originally reported in trace 5.x-1.0 and drupal 5.3:

Fatal error: Call to undefined function drupal_get_path_alias() in /home/mykle/mun3/www/modules/trace/trace.module on line 153

#17

This is a core function and should always be available:

http://api.drupal.org/api/function/drupal_get_path_alias/5

The only thing I can think of is to check whether you in fact have the Path module enabled?

#18

Priority:critical» normal
Status:active» fixed

#19

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.