Needs review
Project:
#states exercise
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Jan 2012 at 21:06 UTC
Updated:
26 May 2012 at 20:46 UTC
Jump to comment: Most recent file
The following patch adds the test coverage provided by peterpoe in #735528: FAPI #states: Fix conditionals to allow OR and XOR constructions. This is just a straight diff from that tarball; I haven't done any cleanup or anything.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | states-exercise-revamp-1413434-4.patch | 23.51 KB | dawehner |
| #4 | interdiff.txt | 3.95 KB | dawehner |
| #3 | states-exercise-revamp-1413434-3.patch | 23.61 KB | peterpoe |
| #1 | conditionals.patch | 23.17 KB | xjm |
| conditionals.patch | 0 bytes | xjm |
Comments
Comment #1
xjmAhem. Let's use
git diff --staged. ;)Comment #2
xjmSummaries.
Trailing whitespace.
Should keep that line.
Comment #3
peterpoe commentedReworked summaries and inline comments, removed trailing whitespaces and removed the $id$ tag.
Comment #4
dawehnerI don't have a real idea why but the patch in #3 didn't applied for me, so i took #2 and added the changes from #3.
This patch is against the 8.x branch.