I hate to be the bearer of bad news, but I've been spoiled by the enhanced images this module generates, and it seems that upgrading to the latest image module has broken something so the two modules no longer work correctly together. I filed the following with the image module but have yet to get a response, so I thought I would post it here as well, in case it something on this end.

-----------------------

I've just upgraded a test site that was successfully using ImageMagick 6.3.2 01/26/07 Q16 on a local WAMP machine along with the 5.x-1.0 version of Image enhanced scaling. (I also copied the latest image.imagemagick.inc file to the includes directory)

I tested it by creating a new image node, and immediately noticed that the generated images were not as "sharp" as they used to be. I then disabled the Image Enhanced Scaling module, tried it again, and got the same "soft" images, implying to me that the module was never executed. - (The image toolkit remains unchanged as imagemagick as does the path to convert.exe)

I have no errors in the log, and wish I could help more, but I wouldn't know how to begin debugging this.

Was there a change in the image module that might explain this action, and/or should I file a bug report with Image enhanced scaling?

Thanks for your help!

Comments

herb’s picture

herb commented

The response I got from Image Module was that this should be corrected in Image Enhanced Scaling. Can anyone else confirm that this is happening, and if so, is it likely that this module will be adapted to work with the new releases of Image? (If I knew how to code, I would attempt to propose a patch) Thanks!

zoo33’s picture

zoo33 commented

By reading the CVS messages for Image module up until version 5.x-1.1 it's not clear to me which change may be causing this. Any chance you can go back to 1.0 to verify that it is in fact a change in Image module that causes your problems?

The code that triggers the Enhanced scaling is up for a little rewrite, which may change the whole scenario. Hoping to do that soon.

zoo33’s picture

zoo33 commented

By reading the CVS messages for Image module up until version 5.x-1.1 it's not clear to me which change may be causing this. Any chance you can go back to 1.0 to verify that it is in fact a change in Image module that causes your problems?

The code that triggers the Enhanced scaling is up for a little rewrite, which may change the whole scenario. Hoping to do that soon.

herb’s picture

herb commented

Glad to hear that this module will be maintained. I did immediately go back to 1.0 and that fixed the problem. This morning I just tried adding a print "test"; line to the image_enhanced_scaling.module in nodeapi at line 123 where it seems to create the sharpened images and then added an image. (It printed test 3 times and stopped display of the page, but the images were correctly scaled and sharpened). I then upgraded to Image 5.x.1.1 and created another image. To my surprise, I got the same result, but when I viewed the images, they were NOT sharpened. FWIW, I disabled GD2 during these tests. Sorry I can't help more.

zoo33’s picture

zoo33 commented

Thanks, that's helpful.

I upgraded to Image.module 5.x-1.1 today and it does seem to break things. I'm almost done with the rewrite I was talking about, and I think that actually fixes it. Stay tuned!

(Yes I will definitely keep maintaining this module as I need it for myself. At least for Drupal 5.)

zoo33’s picture

zoo33 commented

I just committed a new version to CVS. The -dev version should be updated within a couple of hours, so please check if that solves it.

herb’s picture

herb commented

Very Nice! Works great for me. Now I can upgrade the the latest Image Modules. FWIW, although the md5_file hash was correct on the download, I did get a CRC extraction error - but I guess it meant nothing since it seems to work fine. Thanks!

zoo33’s picture

zoo33 commented
Status: Active » Fixed

Thanks for you reports!
Let's call this fixed.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)