I was using the simplenews module to send out html newsletters in 4.7 and noticed that it appeared to no longer have this option on by default when upgrading to 5. When looking through the source in simplenews.module the _simplenews_format_options function, starting on line 2290 in the HEAD version, checks if the Mime Mail module exists and if it does, it adds the HTML option to the newsletter.

Adding a reference to the README.txt file that HTML newsletters need the Mime Mail module.

CommentFileSizeAuthor
#7 readme.141395.patch5.76 KBsutharsan
#2 README.txt_6.patch365 bytesdavemybes
README.txt_5.patch551 bytesm1mic

Comments

m1mic’s picture

m1mic commented
Status: Active » Needs review
davemybes’s picture

davemybes commented
StatusFileSize
new README.txt_6.patch365 bytes

That's a good patch, but I thought that maybe we should also mention that file attachments must also be sent with mimemail. Here's an updated patch with that included.

aaron’s picture

aaron commented

This should also be mentioned on the project page. Perhaps a message as well on the admin settings page, if mimemail isn't yet installed.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

Adding a dependency in simplenews.info would be best.

dependencies = mimemail

gaele’s picture

gaele commented
Status: Needs review » Reviewed & tested by the community

Simplenews is not dependent on Mime Mail. It'll work without it, just not in HTML-mode.

But what's holding this simple patch back?

beginner’s picture

beginner commented

The patch can be committed. It would be a good start. But it is not enough.

The dependency should be mentioned in other places, too, starting from the module's home page (http://drupal.org/project/simplenews).
hook_help() should also be used. See my comments here: http://drupal.org/node/142088#comment-280973

sutharsan’s picture

sutharsan commented
StatusFileSize
new readme.141395.patch5.76 KB

#2 committed and references to simplenews-templates, simplenews-user, (poormans)cron included too. Attached patch for info.
Home page improvements and help pages will follow.

Thanks for bugging me ;)

gaele’s picture

gaele commented
Status: Reviewed & tested by the community » Fixed
sutharsan’s picture

sutharsan commented

hook_help() implemented
Configuration and customization handbook page added: http://drupal.org/node/197057

beginner’s picture

beginner commented

Very good.

Thanks. :)

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.