Simple JSON-RPC server

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

• README.txt is missing, see the guidelines for in-project documentation.
• ./simple_json_rpc_server.install: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function json_rpc_server_schema() {
  

• ./json_rpc_server_node/json_rpc_server_node.module: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function json_rpc_server_node_jsonrpc_services() {
  function json_rpc_server_node_nodeload($nid) {
  function json_rpc_server_node_nodeview($nid, $view_mode = 'full', $langcode = NULL) {
  function json_rpc_server_node_nodesave($arNode) {
  function json_rpc_server_node_nodedelete($nid) {
  

• Remove all old CVS $Id tags, they are not needed anymore.
  

  json_rpc_server_node/json_rpc_server_node.info:1:; $Id$
  

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

Source: http://ventral.org/pareview - PAReview.sh online service

Those files can be seen here:
http://drupalcode.org/sandbox/redsd/1404920.git/tree/refs/heads/master

• Menu items are broken. (http://admin/config/services/jsonrpc/#/methods, instead of http://url/admin/...)

It has to do with your use of base_path() in hook_form().

http://api.drupal.org/api/drupal/includes!common.inc/function/base_path/7
Returns the base URL path (i.e., directory) of the Drupal installation.

So:
http://example.com returns "/" because the path is empty.

Simple fix (don't know if it's the best fix, but works for me):
Add:
global $base_url; to the top of the hook_form() function.

Edit $url variable to:
$url = $base_url . base_path() . current_path();

Changing to needs work, since the links are still broken (atleast for me).

Great module,

1. I think more instruction about how to extend the API should be added.
2. Why there is only a POST request method allowed, I think GET method is commonly used, for example fetching the data from server and render in web page. Others are PUT/DELETE
3. I think the methods list should be kept private.

Regards

Sorry for not checking back earlier, have been busy with work.
Possibly due to the latest changes you've done, code review throws some errors.

http://ventral.org/pareview/httpgitdrupalorgsandboxredsd1404920git

1.) Do not use t() in hook_menu(). You've done so on 6 lines in simple_json_rpc_server.module
2.) You've got a bunch of comments that are longer than 80 chars, split them on multiple lines.
3.) Comments should always end in a full stop. Also, function docblock short description should be on one line.
4.) Make sure you have a space between operator and it's variables (wrong example: if($something) & correct example: if ($something))
5.) Also, your indentation is faulty in some places (simple_json_rpc_server.module and simple_json_rpc_server_node.module).

Apart from those issues found with an automated code review, I couldn't find any problems during a manual code crawl & test.
Fix those, and it's RTBC by me :)

Okay, feel free to come back whenever you like !

Closing due to lack of activity. Feel free to reopen if you are still working on this application.