The function theme_panels_ipe_toolbar does not close one div, what causes other other module's markup to be placed in unexpected positions in DOM.

I had the problem with the admin menu sometimes being rendered at the bottom of the page (inside the panles ipe toolbar).

I will attach a patch that fixes this issue

CommentFileSizeAuthor
#1 panels_ipe_toolbar_markup_fix-1414116-1.patch481 bytespixelmord

Comments

pixelmord’s picture

pixelmord commented
StatusFileSize
new panels_ipe_toolbar_markup_fix-1414116-1.patch481 bytes

Here's the patch

pixelmord’s picture

pixelmord commented
Status: Active » Needs review

forgot to change status....

steven jones’s picture

steven jones commented
Status: Needs review » Reviewed & tested by the community

Confirmed this issue and that this patch fixes 3.0.

The admin menu only sometimes appears 'stuck' in the editor because if the user has the 'has_js' cookie set then admin doesn't dump all the links into the page request, and so it all appears to work nicely.

travisc’s picture

travisc commented

confirmed this patch works, IPE and admin menu is broken without it.

populist’s picture

populist commented

This patch also worked for me.

merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Fixed

This was taken care of as part of another recent commit.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.