After installing the module
at: admin/build/domain/conf/* (domain settings)

i see nothing
all other items work as designed/expected

administer own domains is on.

Did i miss a setting?

I can only edit this page when administer domains is on.
But then the user can edit any domain instead of only the the he owns

any help appreciated
Thanks

Comments

nirbhasa’s picture

nirbhasa commented

No its not your fault :) I have fixed the bug in my local version of the module and will update this version in next day or so.

Thanks!

Nirbhasa

pindaman’s picture

pindaman commented

nirbhasa

you're great thanks. But now I know i worked the whole day...for nothing haha

Hope to see files soon.

Pinda

pindaman’s picture

pindaman commented

you could mail the files to me :)
info [at] pindaman.com

nirbhasa’s picture

nirbhasa commented

Committed to 7.x-1.x branch (at least i think so...something is not right with my git setup here)

pindaman’s picture

pindaman commented

I tried it for the 6.x, but theres an error on my subdomain after enable domain_admin_user. I am logged in as a user(not admin)

array(4) { ["type"]=> int(1) ["message"]=> string(49) "Call to undefined function _domain_admin_access()" ["file"]=> string(128) "/sites/xxx.com/modules/domain_admin/domain_admin_user/domain_admin_user.module" ["line"]=> int(69) }

urldomain/theme/3

call_user_func_array() expects parameter 1 to be a valid callback, function '_domain_admin_settings_access' not found or invalid function name in /includes/menu.inc op regel 452.

being logged in in the main domain as admin/superuser is get also an error:

in the user url: *//domain/users/2

Missing argument 2 for domain_admin_user_form() in /modules/domain_admin/domain_admin_user/domain_admin_user.module op regel 79.

If you can help please...

nirbhasa’s picture

nirbhasa commented
Version: 6.x-1.x-dev » 6.x-1.1

Fixed in newest 1.1 release.

pindaman’s picture

pindaman commented

hi I cab add users,
admin/build/domain/conf/[domain id]
still shows nothing.

module domain_admin
administer own domains is checked for the role

nirbhasa’s picture

nirbhasa commented
Project: Domain Admin » Domain
Version: 6.x-1.1 » 7.x-3.x-dev
Component: Documentation » - Domain Conf
Category: support » feature

I see what is happening now...i was under the impression you couldnt access that page at all.

But in fact you can access the domain settings page, but the page is empty. The reason for this is that you need individual permissions for all the things - eg administer site configuration to change email. This is in fact deliberate, and was indeed the subject of a security release of the Domain Access module.

So I guess the only way around this would be to override the existing permissions. Unfortunately, hook_domainconf is called too late in the game to affect the permissions. Since 6.x version of DA is closed to feature requests, then your best bet, i reckon, would be to modify yourself the function domain_conf_domainbatch and replace the value of the #permission property with 'configure domain settings'.

For D7, I am moving this issue to the Domain Conf queue, as hook_domainbatch can be modified to use the #access FAPI property (which can then be changed by hook_domainconf) instead of the existing permission property.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

That change makes sense. I'll have to look at the code a bit to see the best way to implement.

pindaman’s picture

pindaman commented

I did however added some function into domain_conf.inc.
The code ads analytics for each site/subdomain
see:http://drupal.org/node/547390

When i go to admin/build/domain/conf/[domain id]
I do see the analytics form.
The rest is still empty.

I will look to change domain_conf_domainbatch .
Thanks

pindaman’s picture

pindaman commented

i changed
'#permission' => 'administer site configuration',
to
'#permission' => 'administer own domains',

But i had to change domian_conf.module
Is there a way to do this via domain_conf.inc.
or to add a permission like
'#permission' => 'administer site configuration','administer own domains',
(above does not work, but i hope you now what i mean using OR)

thanks

nirbhasa’s picture

nirbhasa commented

re #10: yes - thats basically by design, as the other items need permissions to access

re #11: unfortunately for D6 the way the form is structured doesnt lend itself to an easy hook override. You could try inserting your own implementation of hook_domainbatch entirely - basically copy the entire function from domain_conf into your own module, and then using hook_form_domain_conf_form_alter to call it.

pindaman’s picture

pindaman commented

function MyModule_domainbatch when added to my module no settings are shown.

I guess i ammissing something. My hook knowlegde is not too good sorry. Also no samples for hook_form_domain_conf_form_alter could be found.

But Thanks for everything nirbhasa. Your help and knowledge

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Closed (works as designed)