Hi Jennifer,
I was actually looking into doing this exact thing for a project last week, but couldn't figure out how to format the Google URL properly. Wow, you made it look so easy! :)

So far in my very limited testing this module seems to work great! I had one feature request that I think would be really helpful. It would be nice if there was a setting to hide the marker bubble by default. I will post a patch for this in just a few minutes.

Thanks for putting this module together. I'm excited to see it progress!

CommentFileSizeAuthor
#11 1414594-Add ability to hide marker bubble-11.patch4.58 KBbocaj
#9 1414594-Add ability to hide marker bubble-9.patch3.29 KBbocaj
#6 1414594-Add ability to hide marker bubble-6.patch3.22 KBbocaj
#4 1414594-Add ability to hide marker bubble-4.patch3.11 KBbocaj
#1 1414594-Add ability to hide marker bubble-1.patch3.11 KBbocaj

Comments

bocaj’s picture

bocaj commented
StatusFileSize
new 1414594-Add ability to hide marker bubble-1.patch3.11 KB

Patch attached.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Looks like a reasonable idea. Does it work? :)

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Active » Needs work

One thing I noticed in your patch: the Yes/No for "is there a marker bubble" is not translated, so it won't work well for international users:

+  $marker_bubble = $settings['marker_bubble'] ? 'Yes' : 'No';
bocaj’s picture

bocaj commented
Status: Needs work » Needs review
StatusFileSize
new 1414594-Add ability to hide marker bubble-4.patch3.11 KB

Good catch! Completely forgot to translate those two options.

Rerolled the patch to take care of that issue.

...and yes, it does work! :)

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

Looks good! I did a slightly more careful review of the patch this time, and I have a couple of concerns:

a) Generally in Drupal code (possibly this is in the coding standards, possibly not), we try to use TRUE/FALSE rather than 1/0 for Boolean options.

b) But actually.... I just noticed this in your code:
+ $marker_bubble = $display['settings']['marker_bubble'] ? 'A' : '';
I'm guessing this means to put an "A" in the marker if TRUE, and that when it's set to '', Google Maps omits the marker entirely. So maybe this could be even more generalized/useful if we made the option "Letter to display in marker" and put in the description "Leave blank to omit marker"?

c) Would this option to omit the marker bubble work on the Google Maps link as well as the embedded map? If so, can we add it there too?

d) 

+  
+  
 
   return $element;

I don't think we really need two extra blank lines here? :)

e) One final thing... I don't think "marker bubble" is the standard term. I think it is just "marker"?

bocaj’s picture

bocaj commented
StatusFileSize
new 1414594-Add ability to hide marker bubble-6.patch3.22 KB

a) How do you set a checkbox form element to have TRUE/FALSE values and not 1/0?

b) No, the "A" doesn't set the letter in the marker. This tells Google Maps what marker bubble to open by default. Google Maps always assigns the first marker A, the second B, third C, etc. Since this module will only ever have one marker, it will always be A. Therefore, if we set the iwloc parameter to A, it's telling Google Maps to open the marker bubble for A on load. An empty string means that the marker bubble shouldn't be open by default.

c) Good idea. Didn't think about this. Included in patch.

d) I have no idea how those got in there. They are removed in patch.

e) Hopefully the answer in b above answers this, but we are dealing directly with the display of the marker bubble (information bubble) not the actual marker itself. The marker will always show, regardless.

Here is an example:
Marker bubble shows on load: http://www.google.com/maps?q=123+Main+Street,+Los+Angeles,+CA&iwloc=A
Marker bubble hidden on load: http://www.google.com/maps?q=123+Main+Street,+Los+Angeles,+CA&iwloc=

bocaj’s picture

bocaj commented
Status: Needs work » Needs review

Oops, forgot to change status back...

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

e) Ahhh, the information bubble. Let's call it the information bubble then. Calling it "marker bubble" confused me into thinking it was the marker. :)

a) I'm OK on the 1/0, given your explanation.

Thanks!

bocaj’s picture

bocaj commented
StatusFileSize
new 1414594-Add ability to hide marker bubble-9.patch3.29 KB

OK. Here is the (hopefully last) patch, changing all instances of marker bubble to information bubble.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Looks good! I think I'd add a code comment to that one line:

+  $information_bubble = $display['settings']['information_bubble'] ? 'A' : '';

with the explanation from #6/b, so that no one would have that question again. I don't see anything else to fix though. I'll try it out sometime soon and commit it.

Do you think I should promote this to a real project instead of a sandbox by the way? So far I think you are the only user I know about (at least the only one who has reported any issues).

bocaj’s picture

bocaj commented
StatusFileSize
new 1414594-Add ability to hide marker bubble-11.patch4.58 KB

Alright. This patch contains a comment explaining the information_bubble functionality.

The patch will hopefully make things easier for you as well. It contains both the information bubble functionality and the patch from #1415746: Add ability to set map zoom rolled together.

I definitely think this should be promoted to a real project. I know at least one other person that would use this pretty regularly on his projects. I'm sure there are others as well. I have been looking for this for awhile, but I couldn't figure out how to get past the coordinates issue...turned out it wasn't an issue at all :) What were you thinking for the project name, simple_gmap? I think that is a good name!

I have another idea for this project as well. How about having a block where the admin can enter an address and it renders into a map? I'm still trying to think what would be the best implementation of this. A hard-coded address wouldn't be bad, but is pretty limiting. I'm still thinking about it... :)

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Excellent, thanks for the combined patch!

- simple_gmap would be the name, yes (I already chose that as the file names and function prefixes).
- Block for address rendering as a map... hm... I think you could pretty easily just do that with a View that references the node you've attached this field to, so I don't think it's necessary to add to this module. A patch for the README that makes this suggestion would be fine though. :)

bocaj’s picture

bocaj commented

I suppose the view for the block implementation would probably work for most (maybe all) cases. That's what I get for trying to think too much! :)

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Fixed

I committed the combined patch, thanks!
http://drupalcode.org/sandbox/jhodgdon/1414358.git/commit/aaec4f8

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

I just filed an issue for discussion about promotion to real project status:
#1415934: Make this a real project?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

By the way, I used the link-to-map formatter in a View on the client project that spurred this module. I haven't tried the embedded map in a View, but I see no reason why that wouldn't work too.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: » 7.x-1.x-dev

To bocaj and anyone else following this issue...

This module has been refactored on #1416452: Make 1 formatter with options to display/not on map, link, and text rather than having multiple formatters, promoted to a full project, renamed, and there is an RC1 release. The release is not backwards compatible with the sandbox module -- if you install it, you will need to go back and choose the new formatter field on your content types and views. Going forward, my intention will be to keep the module more stable than it was during the sandbox phase!