Closed (fixed)
Project:
Find URL Alias
Version:
5.x-1.2
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
5 May 2007 at 01:10 UTC
Updated:
21 May 2007 at 23:04 UTC
i have fixed some bugs in the module. Attached is s patch for all this bugs:
1. not all strings are translatable, fixed
2. code style, many fixes...
3. panels support broken, fixed
4. views support broken, fixed
i will commit a POT file and German translation now.
| Comment | File | Size | Author |
|---|---|---|---|
| find_path.patch | 4.67 KB | hass |
Comments
Comment #1
hass commentedComment #2
starbow commentedThanks, this is a good looking patch.
The whitespace changes might end up getting reverted sometime in the future. I haven't figured out how to get eclipse's code formatter to indent lists (and my personal code style is way off the officially approved target).
Comment #3
hass commentedbut you shouldn't use your own code style... :-). go the drupal way... it think this whitespace changes makes the code more readable. I cannot follow you regarding indent lists? i have used http://drupal.org/node/75242... and this description works well. i took the drupal code style over to all my projects, and feel good.
Comment #4
starbow commentedThis has been rolled into v1.3
Comment #5
starbow commentedThis has been rolled into v1.3
Comment #6
(not verified) commented