Closed (fixed)
Project:
HTML5 Tools
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Jan 2012 at 17:05 UTC
Updated:
12 Feb 2012 at 22:00 UTC
The problem is that you are manually trying to grab the field instance settings out of $form_state, but there is a helper function that does this for you.
link.module seems to do this correctly (now). You might want to check if there are any other fixes in that function that you want to take over, but my change does atleast fix this bug.
| Comment | File | Size | Author |
|---|---|---|---|
| html5_tools_field_widget_instance.patch | 950 bytes | berdir |
Comments
Comment #1
ericduran commentedMakes perfect sense. I'm opening up a followed up issue to see if the link module has changes anything aslo to double check this is still required.
Thanks.
--
http://drupalcode.org/project/html5_tools.git/commit/bd36a5d
Comment #2
ericduran commented@Berdir, FYI, I just push a change to completely change all this. The issue is #1415578: Follow up on the Link Module and you can see the diff over at http://drupalcode.org/project/html5_tools.git/blobdiff/bd36a5deb27d45bd4...
Essentially I stop replacing the link fields process callback. I honestly don't remember why I did that. But it seems unnecessary. Instead I just added another callback and modified what I wanted to change. Which makes the code a lot more manageable and simpler.
Thanks again for the issue :)