| Project: | Drupal core |
| Version: | 8.x-dev |
| Component: | language system |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
| Issue tags: | D8MI, language-content |
Issue Summary
As part of making language support expand wider in Drupal core, we are moving language related code to their respective modules instead of locale/language module implementing it for them on their behalf. This mostly happened for path module in #1236680: Move path language settings from Locale to Path module and is further worked on for path and node modules in #1414314: Make node and path depend on language module only for language support, get rid of locale_language_name and #540294: Move node language settings from Locale to Node module.
The attached patch does the very simple code change to integrate language support in comment module. With this moving out of locale module and being only dependent on node settings, it will make comment support language without locale module being present, which is a major goal for Drupal 8.
The mentioned issues are a set of issues that are going to have their full effect when all land.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| untangle-comment-from-locale.patch | 2.45 KB | Idle | FAILED: [[SimpleTest]]: [MySQL] Invalid PHP syntax in core/modules/comment/comment.module. | View details |
Comments
#1
The last submitted patch, untangle-comment-from-locale.patch, failed testing.
#2
+++ b/core/modules/comment/comment.module@@ -1833,11 +1833,22 @@ function comment_form($form, &$form_state, $comment) {
+ if ($comment_langcode == LANGUAGE_NONE && variable_get('language_content_type_' . $node->type, 0)) {
I know this is how it was before, but can we wrap the first check in parens, please? I hate having to look up/remember operator precedence (== vs. &&).
+++ b/core/modules/comment/comment.module@@ -1833,11 +1833,22 @@ function comment_form($form, &$form_state, $comment) {
+ )
Missing the semi-colon here, as you've probably noticed.
-24 days to next Drupal core point release.
#3
Right! Fixes attached. Thanks for the review.
#4
Wow, your patching speed is insane! :)
Anyway, this is RTBC (if it comes back green).
#5
The last submitted patch, untangle-comment-from-locale-3.patch, failed testing.
#6
#3: untangle-comment-from-locale-3.patch queued for re-testing.
#7
One of the test failures is caused by testHtmlEntitiesSample() that was just committed: #61456: Aggregator titles display quotes and other characters with HTML entity equivalents badly (write tests).
#8
#3: untangle-comment-from-locale-3.patch queued for re-testing.
#9
Tagging as current focus.
#10
I also manually tested this patch and the language inheritance of comments perform the same with or without the patch applied.
#11
I agree that locale.module should not have comment module specific code. Modules should be written with multi-lingual in mind.
Committed this patch to 8.x.
#12
Landed.
#13
Tagging for the content handling leg of D8MI.
#14
Automatically closed -- issue fixed for 2 weeks with no activity.