navigator.id.getVerifiedEmail() has been deprecated:

https://groups.google.com/forum/#!msg/mozilla.dev.identity/p_yPLfvHraM/shqF4krl8B4J

The BrowserID module should use navigator.id.get() instead.

Just wondering, I've been following BrowserID fairly closely and been posting a lot of patches lately, could I get committer access?

CommentFileSizeAuthor
#1 0001-Change-id.getVerifiedEmal-to-id.get-bug-1415988.patch860 bytesSamat Jain

Comments

Samat Jain’s picture

Samat Jain commented
StatusFileSize
new 0001-Change-id.getVerifiedEmal-to-id.get-bug-1415988.patch860 bytes

Patch attached.

icecreamyou’s picture

icecreamyou commented
Status: Needs review » Reviewed & tested by the community

Alright, I gave you full maintainer access. Feel free to go ahead and commit the patch, it looks good to me.

I only ask that as co-maintainer you post an issue for anything you are changing before you commit a change so that I can keep track easily.

icecreamyou’s picture

icecreamyou commented
Status: Reviewed & tested by the community » Fixed

Committed fix to dev

Samat Jain’s picture

Samat Jain commented

Thanks for applying this—totally forgot about it.

On a related note, BrowserID is changing APIs again: https://gist.github.com/2287552

Once they deploy this new API (called the BrowserID observer API) I'll create a new issue & patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.