Field schema foreign keys support is broken

#6: 1416506-field-foreign-keys.patch queued for re-testing.

#1969048: hook_field_schema() cannot vary based on field settings is a related issue (and possible duplicate).

Bumping to major. This affects several contribs and blocks a regression from moving entityreference into core: #1847582: Create a foreign key to the target entity type base type in Entity-reference.

Will need rerolling now CMI conversion is in. Tagging as well.

Will reroll later this evening

Ok, this is trickier after the config conversion, will look later unless someone beats me to it.

- edit -

Sorry for no interdiff, had todo drupal_get_schema('table', TRUE) as we're in a unit test.

Fixing tests. I guess Damien or Yched can sign this off now - if ok of course :)

Duh.

Looks good.

Just minor adjustments:
- Fixed stale code comments
- Removed t()s around test messages

Trailing whitespace.
+ needless double quotes.

Committed and pushed to 8.x. Thanks!

Backport.

Hm, is that better ?

Right, pre-Field/CMI this requires a fix in field_update_field(), and @Damz's original patches accounted for that.

Scratch #27, interdiff is against #25.

This is not a proper review, but I patched 7.22 with the 4 non-test-related lines in that patch (#29). It appears to have fixed the problem in #1340748: Add CTools relationship.

I'm not sure if it's worse to hack 7.22 in my case or if I should rather run 7.x-dev + patch as I need this pretty much right now.

+++ b/modules/field/modules/field_sql_storage/field_sql_storage.moduleundefined
@@ -188,7 +188,7 @@ function _field_sql_storage_schema($field) {
-    foreach ($specification['columns'] as $column => $referenced) {
+    foreach ($specification['columns'] as $column_name => $referenced) {
       $sql_storage_column = _field_sql_storage_columnname($field['field_name'], $column_name);
       $current['foreign keys'][$real_name]['columns'][$sql_storage_column] = $referenced;

awesome!

This worked for me in combination with #44 from #1340748: Add CTools relationship. After applying these patches, I was able to add a Taxonomy from Node relationship in Panels. That wasn't showing as an option before for that field, because it was using an entity reference instead of a term reference.

This helps a lot. Thanks for working on it!

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/9988e47