There was an action on the core node overview to request translation. (hook_node_operations)

The code originally was added by Jose and someone has removed it.
It would be great to see this action back on the list.

CommentFileSizeAuthor
#8 basic_test.patch17.72 KBberdir
#6 multiple_translation.patch13.77 KBberdir

Comments

schnitzel’s picture

Just to think about this:

Here it is possible that a user selects to nodes which should be for example translated from english to german.
Now: Should multiple Jobs be created? Because this is actually a similar functionality as the Cart Module.
Or should we have two Actions:

- Request Translations (Combines nodes as possible)
- Add to Translation Cart (available if Cart Module installed and adds the selected nodes to carts / or creates them if necessary)

miro_dietiker’s picture

Selecting multiple source entities of the same type is not really why a cart exists.
It was always expected to be possible to start on a single entity/source tab and see all source entities listed and you can pick some of them to order.

The cart functionality has been introduced to even do more, like taking source entities from several different source types and have them in one single job.

However the real problem here is that when choosing multiple nodes, it's possible that they don't have a common source language what actually needs to result in multiple jobs... Generally i would always expect to have the system build an aggregated job that contains the chosen items instead of placing multiple jobs (one per entity item).

The problem is here: To cover this functionality, we NEED to have multi-job checkout form.
Else if there's no common source language we would need to stop placing the order.

If there are multiple possible source languages (e.g. all source entity items are available in N languages) then the source language for the job should be selectable.

schnitzel’s picture

The problem is here: To cover this functionality, we NEED to have multi-job checkout form.
Else if there's no common source language we would need to stop placing the order.

100% agree, my words are based on that we have such functionality. Check the Code, there is some functionality in, but as you already created the issue #1416508: Multiple jobs not handled by checkout so we are tracking this and don't have to discuss it in here. Probably we have to ask the person which worked on this.

The Question from my side:
Normally if you select two Target languages in the "Translate" Tab of a Node, you create two Jobs but with each only 1 Item in it (because there is no possibility to create one aggregated job).
Now on a VBO it would be possible to create multiple Items in a Job. But it would also be possible to create multiple Jobs with only 1 Item in it. So my question was actually only if we go for the multiple Items. And this is the way how I would suggest it, I just wanted to make sure that everybody talks about the same ;)

berdir’s picture

Version: » 7.x-1.x-dev

The missing code did exist for example here: http://drupalcode.org/project/tmgmt.git/blob/95b92f26dc7b73642cb0b99c974...

I'm not sure how much we can actually still use of that, but if someone wants to give a try and integrate that into our current UI's, go for it.

I'm not sure sure if we actually need the integration with admin/content because as said elsewhere, that page is imho not helpful as a source overview. It doesn't group by translation sets for example, so you might end up translating nodes from the same set into a common language and you don't see which target languages already exist and so on.

It might make more sense to properly integrate with VBO using hook_action_info() and/or rules and use that on the content source overview.

berdir’s picture

Title: Content overview » Allow to create multiple jobs with multiple items on content source overview
Category: bug » feature
berdir’s picture

Status: Active » Needs review
StatusFileSize
new13.77 KB

Ok, here is a first attempt at this.

It's currently limited to a single source language, so I added a filter that makes the source language required. That's not great, though.

I also had to fix a bug in the submit form when the target_language isn't set.

Status: Needs review » Needs work

The last submitted patch, multiple_translation.patch, failed testing.

berdir’s picture

Status: Needs work » Needs review
StatusFileSize
new17.72 KB

And, here is a simple test for this.

cgalli’s picture

Status: Needs review » Reviewed & tested by the community

Tested with MS Bing and File Import/Export. No mistakes found.

The dependency from Rules is not visible.

berdir’s picture

Commited.

berdir’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.