<em> becomes visible if "remove" link is clicked

hass - May 5, 2007 - 21:51
Project:Go - url redirects
Version:5.x-1.3
Component:Code
Category:bug report
Priority:normal
Assigned:spiderman
Status:closed
Description

This text is displayed on my delete page and should not contain the EM's...

Are you sure you want to remove the go entry with the label <em>www.example.com/forum/</em> ?

Additional, please rename "remove" into "Delete". This string is inside every core translation and therefor it is not required to translate remove only for "Go" module.

#1

BioALIEN - August 23, 2007 - 14:29
Version:5.x-1.2» 5.x-1.3

Just tested the latest branch 1.3 and I can confirm this is still valid. hass, would you like to step in as the module maintainer?

#2

hass - August 23, 2007 - 16:34

Well i already asked, but no one answered my request... a D6 port is 90% done on my box

#3

BioALIEN - August 24, 2007 - 14:57

hass, your wish has been granted :)

You may start with reorganising the CVS trees if you wish.

#4

spiderman - October 29, 2007 - 19:30

hey folks,

just checking on the status of this one- i've fixed the original problem on my test site, and also changed all the 'remove' language to 'delete'. if nobody else is working on this, i'll post a patch for review ;)

#5

BioALIEN - October 30, 2007 - 13:24

@hass, I've emailed you a few times with no response!

@spiderman, if you have a patch ready I see no point in holding this back for D5. We can worry about D6 when it's fully complete :)

#6

hass - October 30, 2007 - 14:52

Bio: jepp i know... maybe my reply is in your spam folder? :-)

#7

spiderman - October 30, 2007 - 17:02
Assigned to:Anonymous» spiderman
Status:active» needs review

ok here's a patch i rolled up- it seems to work fine on my test site, but i'd be glad for extra sets of eyes on this :)

AttachmentSize
gotwo.141671.patch 2.55 KB

#8

spiderman - October 30, 2007 - 17:22

oh right- i should also note that i had to enable the Go list menu callback in order to test this bug- at present, it seems people can't list/remove their gotwo entries?

in that case, then this ticket seems to depend on #141164, which i've followed up here :)

#9

hass - December 30, 2007 - 00:07

I'd like to note that this bugs have been fixed in D6 version.

#10

spiderman - March 4, 2008 - 03:34
Status:needs review» fixed

i've re-rolled this patch and committed it here

#11

Anonymous (not verified) - March 18, 2008 - 03:41
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.