This text is displayed on my delete page and should not contain the EM's...

Are you sure you want to remove the go entry with the label <em>www.example.com/forum/</em> ?

Additional, please rename "remove" into "Delete". This string is inside every core translation and therefor it is not required to translate remove only for "Go" module.

CommentFileSizeAuthor
#7 gotwo.141671.patch2.55 KBspiderman

Comments

BioALIEN’s picture

BioALIEN commented
Version: 5.x-1.2 » 5.x-1.3

Just tested the latest branch 1.3 and I can confirm this is still valid. hass, would you like to step in as the module maintainer?

hass’s picture

hass commented

Well i already asked, but no one answered my request... a D6 port is 90% done on my box

BioALIEN’s picture

BioALIEN commented

hass, your wish has been granted :)

You may start with reorganising the CVS trees if you wish.

spiderman’s picture

spiderman
he/they
Primary language English
Location Halifax, NS
commented

hey folks,

just checking on the status of this one- i've fixed the original problem on my test site, and also changed all the 'remove' language to 'delete'. if nobody else is working on this, i'll post a patch for review ;)

BioALIEN’s picture

BioALIEN commented

@hass, I've emailed you a few times with no response!

@spiderman, if you have a patch ready I see no point in holding this back for D5. We can worry about D6 when it's fully complete :)

hass’s picture

hass commented

Bio: jepp i know... maybe my reply is in your spam folder? :-)

spiderman’s picture

spiderman
he/they
Primary language English
Location Halifax, NS
commented
Assigned: Unassigned » spiderman
Status: Active » Needs review
StatusFileSize
new gotwo.141671.patch2.55 KB

ok here's a patch i rolled up- it seems to work fine on my test site, but i'd be glad for extra sets of eyes on this :)

spiderman’s picture

spiderman
he/they
Primary language English
Location Halifax, NS
commented

oh right- i should also note that i had to enable the Go list menu callback in order to test this bug- at present, it seems people can't list/remove their gotwo entries?

in that case, then this ticket seems to depend on #141164, which i've followed up here :)

hass’s picture

hass commented

I'd like to note that this bugs have been fixed in D6 version.

spiderman’s picture

spiderman
he/they
Primary language English
Location Halifax, NS
commented
Status: Needs review » Fixed

i've re-rolled this patch and committed it here

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.