i have an URL named "/go/forum" that redirects to "http://example.com/forum". clicking the link will not change the counter.

CommentFileSizeAuthor
#5 gotwo_0.patch4.75 KBhass

Comments

jredding’s picture

jredding commented

hhm.. works on my install. I won't have time to fix any of these issue for another month or so. I'm out traveling.

At this point its best to submit patches rather than bug reports as this module does not have an active maintainer.

jredding’s picture

jredding commented
Assigned: Unassigned » jredding
Status: Active » Fixed

Counter is incrementing on my install with version 5.1.2; 5.1.1 is really screwed up.

hass’s picture

hass commented

tested again, the counter does not increment.

hass’s picture

hass commented
Status: Fixed » Active

tested again, the counter does not increment.

hass’s picture

hass commented
Status: Active » Needs review
StatusFileSize
new gotwo_0.patch4.75 KB

The not incrementing counter bug is caused by db_rewrite_sql around the UPDATE. i wonder why you are not able to repro this bug. I'm using MySQL 5.0.

What have been fixed with this patch:
1. the db_rewrite_sql has been removed from the UPDATE request.
2. many code style bugs
3. some SQL bugs with %d (single quotes sometimes produce db errors and request a string conversion)
4. upgrade bugs in t() from 4.7.x > 5.x (theme placeholder logic has changed with 5.x)

Read the drupal coding rules carefully (especially about IF ELSE), please! Not all code style bugs are fixed yet, but some.

Aside it looks like you are developing in the wrong branch... 5.x development should be done in a 5.x tree. D6 in HEAD. This make sure the 5.x-dev release is every time the latest version... if you developing in cvs the 5.x-dev release will not updated nightly after a change.

jredding’s picture

jredding commented
Status: Needs review » Fixed

patch was committed. Unfortunately I will not be updating this module to 6. It is currently unmaintained

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)